[ 
https://issues.apache.org/jira/browse/ARROW-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275105#comment-16275105
 ] 

ASF GitHub Bot commented on ARROW-1785:
---------------------------------------

siddharthteotia commented on issue #1297: ARROW-1785: [Format/C++/Java] Remove 
VectorLayout from serialized schemas
URL: https://github.com/apache/arrow/pull/1297#issuecomment-348632457
 
 
   Looks like the java side of changes are messed up because of rebase commits? 
I am seeing code changes (like removal of non-nullable vectors) and those are 
not the java changes made by this PR. It is hard to make out what are we doing 
on the JAVA side as far this PR is concerned.
   
   I can see that ArrowVectorType  and VectorLayout have been removed and we 
are using BufferType and BufferLayout instead. Is that correct? 
   
   I believe that these objects are still part of serialized schema -- it's 
just that names have changed.  Instead of ArrowVectorType, we have BufferType 
and instead of VectorLayout we have BufferLayout. Is the correct summary of 
JAVA side changes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [Format] Remove VectorLayout metadata from Flatbuffers metadata
> ---------------------------------------------------------------
>
>                 Key: ARROW-1785
>                 URL: https://issues.apache.org/jira/browse/ARROW-1785
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++, Format, Java - Vectors
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> Based on the discussions on the mailing list, we should remove the 
> VectorLayout metadata from the Flatbuffers spec for 0.8.0 since we are 
> already breaking the metadata. We should instead make the buffer layouts an 
> immutable part of the format specification so there is no ambiguity about 
> what buffers accompany each type of field in an Arrow payload
> see also ARROW-1693



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to