[ 
https://issues.apache.org/jira/browse/ARROW-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275933#comment-16275933
 ] 

Licht Takeuchi edited comment on ARROW-1483 at 12/3/17 1:29 PM:
----------------------------------------------------------------

[~wesmckinn] Seems fixed by my 
[PR|https://github.com/apache/arrow/commit/59030fe1d319d36157554fb7880e9b574c60a3d1].
 But tests is not exist. I will add some tests.

{code:java}
>>> a = pa.array(np.array([1000, 2000, 3000], dtype='int64'), 
>>> type=pa.time64('us'))
>>> a
<pyarrow.lib.Time64Array object at 0x112cb7ec0>
[
  datetime.time(0, 0, 0, 1000),
  datetime.time(0, 0, 0, 2000),
  datetime.time(0, 0, 0, 3000)
]
>>> a.cast(pa.time32('ms'))
<pyarrow.lib.Time32Array object at 0x112cb7f18>
[
  datetime.time(0, 0, 0, 1000),
  datetime.time(0, 0, 0, 2000),
  datetime.time(0, 0, 0, 3000)
]
>>>
>>>
>>> b = pa.array(np.array([1, 2, 3], dtype='int32'), type=pa.time32('ms'))
>>> b.cast(pa.time32('ms'))
<pyarrow.lib.Time32Array object at 0x112cb7f70>
[
  datetime.time(0, 0, 0, 1000),
  datetime.time(0, 0, 0, 2000),
  datetime.time(0, 0, 0, 3000)
]
>>> a.cast(pa.time64('us'))
<pyarrow.lib.Time64Array object at 0x112cb7f18>
[
  datetime.time(0, 0, 0, 1000),
  datetime.time(0, 0, 0, 2000),
  datetime.time(0, 0, 0, 3000)
]
{code}



was (Author: licht-t):
[~wesmckinn] Seems fixed by my 
[PR|https://github.com/apache/arrow/commit/59030fe1d319d36157554fb7880e9b574c60a3d1].
 But tests is not exist. I will add some tests.

{code:java}
>>> a = pa.array(np.array([1000, 2000, 3000], dtype='int64'), 
>>> type=pa.time64('us'))
>>> a
<pyarrow.lib.Time64Array object at 0x112cb7ec0>
[
  datetime.time(0, 0, 0, 1000),
  datetime.time(0, 0, 0, 2000),
  datetime.time(0, 0, 0, 3000)
]
>>> a.cast(pa.time32('ms'))
<pyarrow.lib.Time32Array object at 0x112cb7f18>
[
  datetime.time(0, 0, 0, 1000),
  datetime.time(0, 0, 0, 2000),
  datetime.time(0, 0, 0, 3000)
]
>>>
>>>
>>> b = pa.array(np.array([1, 2, 3], dtype='int32'), type=pa.time32('ms'))
>>> a.cast(pa.time32('ms'))
<pyarrow.lib.Time32Array object at 0x112cb7f70>
[
  datetime.time(0, 0, 0, 1000),
  datetime.time(0, 0, 0, 2000),
  datetime.time(0, 0, 0, 3000)
]
>>> a.cast(pa.time64('us'))
<pyarrow.lib.Time64Array object at 0x112cb7f18>
[
  datetime.time(0, 0, 0, 1000),
  datetime.time(0, 0, 0, 2000),
  datetime.time(0, 0, 0, 3000)
]
{code}


> [C++] Implement casts between time32 and time64
> -----------------------------------------------
>
>                 Key: ARROW-1483
>                 URL: https://issues.apache.org/jira/browse/ARROW-1483
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: C++
>            Reporter: Wes McKinney
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to