[
https://issues.apache.org/jira/browse/ARROW-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279045#comment-16279045
]
ASF GitHub Bot commented on ARROW-1881:
---------------------------------------
wesm closed pull request #1391: ARROW-1881: Ignore JS tags for Python packages
URL: https://github.com/apache/arrow/pull/1391
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/setup.py b/python/setup.py
index 2270cf79c..b56a4fdca 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -395,6 +395,16 @@ def has_ext_modules(foo):
install_requires.append('futures')
+def parse_version(root):
+ from setuptools_scm import version_from_scm
+ import setuptools_scm.git
+ describe = setuptools_scm.git.DEFAULT_DESCRIBE + " --exclude
'apache-arrow-js-*'"
+ version = setuptools_scm.git.parse(root, describe)
+ if not version:
+ return version_from_scm(root)
+ else:
+ return version
+
setup(
name="pyarrow",
packages=['pyarrow', 'pyarrow.tests'],
@@ -413,7 +423,7 @@ def has_ext_modules(foo):
'plasma_store = pyarrow:_plasma_store_entry_point'
]
},
- use_scm_version={"root": "..", "relative_to": __file__},
+ use_scm_version={"root": "..", "relative_to": __file__, "parse":
parse_version},
setup_requires=['setuptools_scm', 'cython >= 0.23'],
install_requires=install_requires,
tests_require=['pytest'],
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] setuptools_scm picks up JS version tags
> ------------------------------------------------
>
> Key: ARROW-1881
> URL: https://issues.apache.org/jira/browse/ARROW-1881
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Building wheels from the current master will end up in
> {{pyarrow-0.2.1.dev15+g3b438bc-cp36-cp36m-manylinux1_x86_64.whl}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
