[
https://issues.apache.org/jira/browse/ARROW-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280142#comment-16280142
]
ASF GitHub Bot commented on ARROW-1890:
---------------------------------------
xhochy commented on a change in pull request #1393: ARROW-1890: [Python] Fix
mask handling for Date32 NumPy conversions
URL: https://github.com/apache/arrow/pull/1393#discussion_r155228899
##########
File path: cpp/src/arrow/python/numpy_to_arrow.cc
##########
@@ -120,6 +120,7 @@ int64_t MaskToBitmap(PyArrayObject* mask, int64_t length,
uint8_t* bitmap) {
for (int i = 0; i < length; ++i) {
if (mask_values[i]) {
++null_count;
+ BitUtil::ClearBit(bitmap, i);
Review comment:
This is needed because the bitmap is already filled by a previously run
ValuesToBitmap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Masking for date32 arrays not working
> ----------------------------------------------
>
> Key: ARROW-1890
> URL: https://issues.apache.org/jira/browse/ARROW-1890
> Project: Apache Arrow
> Issue Type: Bug
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Labels: pull-request-available
>
> {code}
> arr = np.array([date(2017, 4, 3), date(2017, 4, 4)], dtype='datetime64[D]')
> mask = [True, False]
> t32 = pa.date32()
> result = pa.array(arr, mask=np.array(mask))
> expected = pa.array(np.array([None, date(2017, 4, 4)], dtype='datetime64[D]'))
> {code}
> The above code produces an array that has no null values.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
