[
https://issues.apache.org/jira/browse/ARROW-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280373#comment-16280373
]
ASF GitHub Bot commented on ARROW-1889:
---------------------------------------
xhochy closed pull request #1392: ARROW-1889: [Python] --exclude is not
available in older git versions
URL: https://github.com/apache/arrow/pull/1392
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/setup.py b/python/setup.py
index b56a4fdca..81115869b 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -398,7 +398,7 @@ def has_ext_modules(foo):
def parse_version(root):
from setuptools_scm import version_from_scm
import setuptools_scm.git
- describe = setuptools_scm.git.DEFAULT_DESCRIBE + " --exclude
'apache-arrow-js-*'"
+ describe = setuptools_scm.git.DEFAULT_DESCRIBE + " --match
'apache-arrow-[0-9]*'"
version = setuptools_scm.git.parse(root, describe)
if not version:
return version_from_scm(root)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] --exclude is not available in older git versions
> ---------------------------------------------------------
>
> Key: ARROW-1889
> URL: https://issues.apache.org/jira/browse/ARROW-1889
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Affects Versions: 0.8.0
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Labels: pull-request-available
>
> The workaround implemented yesterday for the version determination uses Git's
> {{--exclude}} option which is only available on very recent versions of Git.
> Instead we should use a {{--match}} expression that only matches the non-JS
> tags.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
