[
https://issues.apache.org/jira/browse/ARROW-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280706#comment-16280706
]
ASF GitHub Bot commented on ARROW-1857:
---------------------------------------
wesm closed pull request #1395: ARROW-1857: [Python] Add switch for boost
linkage with static parquet in wheels
URL: https://github.com/apache/arrow/pull/1395
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
index 00a4ee687..cbbb464d0 100644
--- a/python/CMakeLists.txt
+++ b/python/CMakeLists.txt
@@ -64,6 +64,9 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
option(PYARROW_PARQUET_USE_SHARED
"Rely on parquet shared libraries where relevant"
ON)
+ option(PYARROW_BOOST_USE_SHARED
+ "Rely on boost shared libraries on linking static parquet"
+ OFF)
option(PYARROW_BUILD_PLASMA
"Build the PyArrow Plasma integration"
OFF)
@@ -306,7 +309,11 @@ if (PYARROW_BUILD_PARQUET)
parquet_shared)
else()
find_package(Thrift)
- set(Boost_USE_STATIC_LIBS ON)
+ if (PYARROW_BOOST_USE_SHARED)
+ set(Boost_USE_STATIC_LIBS OFF)
+ else()
+ set(Boost_USE_STATIC_LIBS ON)
+ endif()
find_package(Boost COMPONENTS regex REQUIRED)
ADD_THIRDPARTY_LIB(boost_regex
STATIC_LIB ${Boost_REGEX_LIBRARY_RELEASE})
diff --git a/python/setup.py b/python/setup.py
index b56a4fdca..8b93e9910 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -105,6 +105,8 @@ def initialize_options(self):
os.environ.get('PYARROW_WITH_PARQUET', '0'))
self.with_static_parquet = strtobool(
os.environ.get('PYARROW_WITH_STATIC_PARQUET', '0'))
+ self.with_static_boost = strtobool(
+ os.environ.get('PYARROW_WITH_STATIC_BOOST', '1'))
self.with_plasma = strtobool(
os.environ.get('PYARROW_WITH_PLASMA', '0'))
self.bundle_arrow_cpp = strtobool(
@@ -149,6 +151,8 @@ def _run_cmake(self):
cmake_options.append('-DPYARROW_BUILD_PARQUET=on')
if self.with_static_parquet:
cmake_options.append('-DPYARROW_PARQUET_USE_SHARED=off')
+ if not self.with_static_boost:
+ cmake_options.append('-DPYARROW_BOOST_USE_SHARED=on')
if self.with_plasma:
cmake_options.append('-DPYARROW_BUILD_PLASMA=on')
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Add switch for boost linkage with static parquet in wheels
> -------------------------------------------------------------------
>
> Key: ARROW-1857
> URL: https://issues.apache.org/jira/browse/ARROW-1857
> Project: Apache Arrow
> Issue Type: New Feature
> Components: Python
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Currently we will always link {{boost_regex}} statically, in some build
> situation, shared linkage is preferred.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
