[
https://issues.apache.org/jira/browse/ARROW-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281026#comment-16281026
]
ASF GitHub Bot commented on ARROW-1877:
---------------------------------------
vkorukanti commented on issue #1380: ARROW-1877: [Java] Fix incorrect equals
method in JsonStringArrayList
URL: https://github.com/apache/arrow/pull/1380#issuecomment-349794758
Comparing with `AbstractMap#equals()`, looks like we are not handling the
some exceptions correctly. I will update the patch to remove `equals` in
`JsonStringHashMap`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Incorrect comparison in JsonStringArrayList.equals
> --------------------------------------------------
>
> Key: ARROW-1877
> URL: https://issues.apache.org/jira/browse/ARROW-1877
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Affects Versions: 0.1.0
> Reporter: Venki Korukanti
> Assignee: Venki Korukanti
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> [1] uses containsAll which could return wrong results. Ex. e1: [true, true,
> false], e2: [true, false, false].
> Remove the equals method and fallback on super class method which has correct
> implementation.
> [1]
> https://github.com/apache/arrow/blob/7a4026a2b43b164ac28c96e1e796c02ca9efe496/java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringArrayList.java#L55
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
