[
https://issues.apache.org/jira/browse/ARROW-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281086#comment-16281086
]
ASF GitHub Bot commented on ARROW-1895:
---------------------------------------
jorisvandenbossche commented on a change in pull request #1397: ARROW-1895:
[Python] Add field_name to pandas index metadata
URL: https://github.com/apache/arrow/pull/1397#discussion_r155386391
##########
File path: python/pyarrow/pandas_compat.py
##########
@@ -450,9 +459,31 @@ def table_to_blockmanager(options, table, memory_pool,
nthreads=1,
block_table = table
+ index_columns_set = frozenset(index_columns)
+
+ # 1. 'field_name' is the user-facing name of the column in an arrow Table
Review comment:
in the comment below you already describe the logical name as the
"user-facing" name ("There must be the same number of logical names
(user-facing) and physical names (fields in the arrow Table)")
I would add here as well an explanation how a "logical name" should be
interpreted for clarity
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Add field_name to pandas index metadata
> ------------------------------------------------
>
> Key: ARROW-1895
> URL: https://issues.apache.org/jira/browse/ARROW-1895
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Affects Versions: 0.7.1
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> See the discussion here for details:
> https://github.com/pandas-dev/pandas/pull/18201
> In short we need a way to map index column names to field names in an arrow
> Table.
> Additionally, we're depending on the index columns being written at the end
> of the table and fixing this would allow us to read metadata written by other
> systems (e.g., fastparquet) that don't make this assumption.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
