Paul Taylor created ARROW-1903:
----------------------------------
Summary: [JS] Fix typings consuming apache-arrow module when
noImplicitAny is false
Key: ARROW-1903
URL: https://issues.apache.org/jira/browse/ARROW-1903
Project: Apache Arrow
Issue Type: Bug
Components: JavaScript
Affects Versions: 0.8.0
Reporter: Paul Taylor
Assignee: Paul Taylor
The TypeScript compiler has a few bugs that raise compiler errors when valid
strict-mode code is compiled with some of the strict mode-settings disabled.
Since we ship the TS source code in the main `apache-arrow` npm module,
consumers will encounter the following TypeScript compiler errors under these
conditions:
{code}
# --strictNullChecks=true, --noImplicitAny=false
vector/numeric.ts(57,17): error TS2322: Type 'number' is not assignable to type
'never'.
vector/numeric.ts(61,35): error TS2322: Type 'number' is not assignable to type
'never'.
vector/numeric.ts(63,18): error TS2322: Type '0' is not assignable to type
'never'.
vector/virtual.ts(98,38): error TS2345: Argument of type 'TypedArray' is not
assignable to parameter of type 'never'.
{code}
The fixes are minor, and I'll add a step in the unit tests to validate the
build targets compile with different compilation flags than ours.
Related:
https://github.com/ReactiveX/IxJS/pull/167
https://github.com/Microsoft/TypeScript/issues/20299
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
