[
https://issues.apache.org/jira/browse/ARROW-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288373#comment-16288373
]
ASF GitHub Bot commented on ARROW-1917:
---------------------------------------
wesm closed pull request #1417: ARROW-1917: Fixes to enable
verify-release-candidate.sh to work for 0.8.0
URL: https://github.com/apache/arrow/pull/1417
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dev/release/verify-release-candidate.sh
b/dev/release/verify-release-candidate.sh
index 7c5e7fd0a..f33211e26 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -165,7 +165,9 @@ test_glib() {
make -j$NPROC
make install
- NO_MAKE=yes test/run-test.sh
+ GI_TYPELIB_PATH=$ARROW_HOME/lib/girepository-1.0 \
+ NO_MAKE=yes \
+ test/run-test.sh
popd
}
@@ -174,15 +176,17 @@ test_js() {
pushd js
npm install
# clean, lint, and build JS source
- npm run clean:all
- npm run lint
- npm run build
+ npx run-s clean:all lint build
+ npm run test
+
# create initial integration test data
- npm run create:testdata
+ # npm run create:testdata
+
# run once to write the snapshots
- npm test -- -t ts -u --integration
+ # npm test -- -t ts -u --integration
+
# run again to test all builds against the snapshots
- npm test -- --integration
+ # npm test -- --integration
popd
}
@@ -238,13 +242,14 @@ fetch_archive $DIST_NAME
tar xvzf ${DIST_NAME}.tar.gz
cd ${DIST_NAME}
+test_package_java
setup_miniconda
test_and_install_cpp
+test_integration
+test_glib
install_parquet_cpp
test_python
-test_glib
-test_package_java
-test_integration
+
test_js
echo 'Release candidate looks good!'
diff --git a/java/pom.xml b/java/pom.xml
index 162c53460..922048c01 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -41,8 +41,8 @@
</properties>
<scm>
-
<connection>scm:git:https://git-wip-us.apache.org/repos/asf/arrow.git</connection>
-
<developerConnection>scm:git:https://git-wip-us.apache.org/repos/asf/arrow.git</developerConnection>
+ <connection>scm:git:https://github.com/apache/arrow.git</connection>
+
<developerConnection>scm:git:https://github.com/apache/arrow.git</developerConnection>
<url>https://github.com/apache/arrow</url>
<tag>apache-arrow-0.7.1</tag>
</scm>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [GLib] Must set GI_TYPELIB_PATH in verify-release-candidate.sh
> --------------------------------------------------------------
>
> Key: ARROW-1917
> URL: https://issues.apache.org/jira/browse/ARROW-1917
> Project: Apache Arrow
> Issue Type: Bug
> Components: GLib
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> This is a new necessary step when validating a release candidate
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
