[
https://issues.apache.org/jira/browse/ARROW-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294532#comment-16294532
]
ASF GitHub Bot commented on ARROW-1919:
---------------------------------------
wesm commented on a change in pull request #1421: ARROW-1919: [Plasma] Test
that object ids are 20 bytes
URL: https://github.com/apache/arrow/pull/1421#discussion_r157403940
##########
File path: python/pyarrow/plasma.pyx
##########
@@ -136,6 +136,9 @@ cdef class ObjectID:
CUniqueID data
def __cinit__(self, object_id):
+ if not isinstance(object_id, bytes) or len(object_id) != 20:
+ raise RuntimeError("Object ID must by 20 bytes,"
Review comment:
Can you raise `ValueError` instead here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Plasma hanging if object id is not 20 bytes
> -------------------------------------------
>
> Key: ARROW-1919
> URL: https://issues.apache.org/jira/browse/ARROW-1919
> Project: Apache Arrow
> Issue Type: Bug
> Reporter: Philipp Moritz
> Assignee: Philipp Moritz
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> This happens if plasma's capability to put an object with a user defined
> object id is used if the object id is not 20 bytes long. Plasma will hang
> upon get in that case, we should give an error instead.
> See https://github.com/ray-project/ray/issues/1315
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
