[ 
https://issues.apache.org/jira/browse/ARROW-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295455#comment-16295455
 ] 

ASF GitHub Bot commented on ARROW-1920:
---------------------------------------

jcrist commented on issue #1418: ARROW-1920 [C++/Python] Add ORC Reader
URL: https://github.com/apache/arrow/pull/1418#issuecomment-352523219
 
 
   > These are probably due to liborc symbols not being hidden in the generated 
shared libraries. If you like I can make a PR to your PR to fix this.
   
   That'd be useful, I don't fully understand what the `symbols.map` file is 
doing.
   
   > In general, we follow the Google C++ styleguide in Arrow. One of the 
specialities of it is that unsigned integers are not used.
   
   I've removed the use of unsigned integers in several (but not all) places. 
These were used to match the api of `liborc`, which makes heavy use of them. I 
could remove them completely, but would need to explicitly check range and cast 
when interacting with `liborc` then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add support for reading ORC files
> ---------------------------------
>
>                 Key: ARROW-1920
>                 URL: https://issues.apache.org/jira/browse/ARROW-1920
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: C++, Python
>            Reporter: Jim Crist
>              Labels: pull-request-available
>
> Would be nice to be able to read ORC files in pyarrow, similar to the already 
> existing parquet support.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to