[
https://issues.apache.org/jira/browse/ARROW-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305826#comment-16305826
]
ASF GitHub Bot commented on ARROW-1948:
---------------------------------------
BryanCutler closed pull request #1447: ARROW-1948: [Java] Load ListVector
validity buffer with BitVectorHelper to handle all non-null
URL: https://github.com/apache/arrow/pull/1447
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
b/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
index d50d4c447..0c1daf490 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/complex/ListVector.java
@@ -124,7 +124,7 @@ public void loadFieldBuffers(ArrowFieldNode fieldNode,
List<ArrowBuf> ownBuffers
ArrowBuf offBuffer = ownBuffers.get(1);
validityBuffer.release();
- validityBuffer = bitBuffer.retain(allocator);
+ validityBuffer = BitVectorHelper.loadValidityBuffer(fieldNode, bitBuffer,
allocator);
offsetBuffer.release();
offsetBuffer = offBuffer.retain(allocator);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] ListVector does not handle ipc with all non-null values with none set
> ----------------------------------------------------------------------------
>
> Key: ARROW-1948
> URL: https://issues.apache.org/jira/browse/ARROW-1948
> Project: Apache Arrow
> Issue Type: Bug
> Components: Java - Vectors
> Affects Versions: 0.8.0
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
>
> It is valid for ipc to send a validity buffer with no values set that
> indicate all values are non-null. This is already handled by all vectors
> except ListVector, which will throw an invalid index exception when this is
> the case because it does not build the validity buffer with all elements set.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
