[
https://issues.apache.org/jira/browse/ARROW-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308950#comment-16308950
]
ASF GitHub Bot commented on ARROW-1962:
---------------------------------------
BryanCutler commented on issue #1455: [WIP] ARROW-1962: [Java] Adding reset to
ValueVector interface
URL: https://github.com/apache/arrow/pull/1455#issuecomment-354917163
ping @icexelloss @siddharthteotia , I found that `reset()` is implemented in
some vector classes, but not part of the ValueVector interface. It was being
used in Spark prior to the refactoring, so it would be helpful to add to the
common interface. What do you guys think?
Also, I noticed `BaseDataValueVector` seemed to be leftover from the
refactoring and not used anywhere. Is this being used by anyone downstream or
safe to clean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Add reset() to ValueVector interface
> -------------------------------------------
>
> Key: ARROW-1962
> URL: https://issues.apache.org/jira/browse/ARROW-1962
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
>
> The {{reset()}} method exists in some ValueVectors but not all. Its meaning
> is that it will bring the vector to an empty state, but not release any
> buffers (as opposed to clear() which resets and releases buffers).
> It should be added to the {{ValueVector}} interface and implemented in the
> vector hierarchy where it currently is not.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
