[
https://issues.apache.org/jira/browse/ARROW-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312345#comment-16312345
]
ASF GitHub Bot commented on ARROW-1909:
---------------------------------------
wesm closed pull request #1406: ARROW-1909: [C++] Enables building with
benchmarks on windows
URL: https://github.com/apache/arrow/pull/1406
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/src/arrow/compute/compute-benchmark.cc
b/cpp/src/arrow/compute/compute-benchmark.cc
index aa7d899c8..44df44139 100644
--- a/cpp/src/arrow/compute/compute-benchmark.cc
+++ b/cpp/src/arrow/compute/compute-benchmark.cc
@@ -191,7 +191,7 @@ static void BM_UniqueString100bytes(benchmark::State&
state) {
BENCHMARK(BM_BuildDictionary)->MinTime(1.0)->Unit(benchmark::kMicrosecond);
BENCHMARK(BM_BuildStringDictionary)->MinTime(1.0)->Unit(benchmark::kMicrosecond);
-constexpr int64_t kHashBenchmarkLength = 1 << 24;
+constexpr int kHashBenchmarkLength = 1 << 24;
#define ADD_HASH_ARGS(WHAT) \
WHAT->Args({kHashBenchmarkLength, 50}) \
diff --git a/cpp/src/arrow/util/CMakeLists.txt
b/cpp/src/arrow/util/CMakeLists.txt
index 42613d6a5..a36dffb52 100644
--- a/cpp/src/arrow/util/CMakeLists.txt
+++ b/cpp/src/arrow/util/CMakeLists.txt
@@ -57,6 +57,11 @@ if (ARROW_BUILD_BENCHMARKS)
target_link_libraries(arrow_benchmark_main
benchmark
)
+ elseif(MSVC)
+ target_link_libraries(arrow_benchmark_main
+ benchmark
+ Shlwapi.lib
+ )
else()
target_link_libraries(arrow_benchmark_main
benchmark
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Bug: Build fails on windows with "-DARROW_BUILD_BENCHMARKS=ON"
> --------------------------------------------------------------------
>
> Key: ARROW-1909
> URL: https://issues.apache.org/jira/browse/ARROW-1909
> Project: Apache Arrow
> Issue Type: Bug
> Reporter: Adam Seibert
> Assignee: Adam Seibert
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> It appears to be an issue with building google/benchmark.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
