[
https://issues.apache.org/jira/browse/ARROW-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316977#comment-16316977
]
ASF GitHub Bot commented on ARROW-1969:
---------------------------------------
wesm closed pull request #1457: ARROW-1969: [C++] Don't build ORC extension by
default
URL: https://github.com/apache/arrow/pull/1457
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index ddadf739a..58d6786aa 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -54,6 +54,7 @@ matrix:
- export ARROW_TRAVIS_USE_TOOLCHAIN=1
- export ARROW_TRAVIS_VALGRIND=1
- export ARROW_TRAVIS_PLASMA=1
+ - export ARROW_TRAVIS_ORC=1
- export ARROW_TRAVIS_CLANG_FORMAT=1
- export ARROW_BUILD_WARNING_LEVEL=CHECKIN
- export CC="clang-4.0"
@@ -75,6 +76,7 @@ matrix:
before_script:
- export ARROW_TRAVIS_USE_TOOLCHAIN=1
- export ARROW_TRAVIS_PLASMA=1
+ - export ARROW_TRAVIS_ORC=1
- export ARROW_BUILD_WARNING_LEVEL=CHECKIN
- travis_wait 50 $TRAVIS_BUILD_DIR/ci/travis_before_script_cpp.sh
script:
diff --git a/ci/travis_before_script_cpp.sh b/ci/travis_before_script_cpp.sh
index 664f7ce5f..fd2c16446 100755
--- a/ci/travis_before_script_cpp.sh
+++ b/ci/travis_before_script_cpp.sh
@@ -84,6 +84,10 @@ if [ $ARROW_TRAVIS_PLASMA == "1" ]; then
CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_PLASMA=ON"
fi
+if [ $ARROW_TRAVIS_ORC == "1" ]; then
+ CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_ORC=ON"
+fi
+
if [ $ARROW_TRAVIS_VALGRIND == "1" ]; then
CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_TEST_MEMCHECK=ON"
fi
diff --git a/ci/travis_script_python.sh b/ci/travis_script_python.sh
index 444386fdf..9e74906d0 100755
--- a/ci/travis_script_python.sh
+++ b/ci/travis_script_python.sh
@@ -63,6 +63,7 @@ cmake -GNinja \
-DARROW_BUILD_UTILITIES=off \
-DARROW_PLASMA=on \
-DARROW_PYTHON=on \
+ -DARROW_ORC=on \
-DCMAKE_BUILD_TYPE=$ARROW_BUILD_TYPE \
-DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
$ARROW_CPP_DIR
@@ -88,6 +89,7 @@ popd
python -c "import pyarrow.parquet"
python -c "import pyarrow.plasma"
+python -c "import pyarrow.orc"
if [ $TRAVIS_OS_NAME == "linux" ]; then
export PLASMA_VALGRIND=1
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index ede13af5d..0558cba49 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -121,7 +121,7 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
option(ARROW_ORC
"Build the Arrow ORC adapter"
- ON)
+ OFF)
option(ARROW_JEMALLOC
"Build the Arrow jemalloc-based allocator"
diff --git a/cpp/README.md b/cpp/README.md
index 92e87cb43..39a1ccac6 100644
--- a/cpp/README.md
+++ b/cpp/README.md
@@ -145,6 +145,13 @@ The CUDA toolchain used to build the library can be
customized by using the
This library is still in Alpha stages, and subject to API changes without
deprecation warnings.
+### Building Apache ORC integration (optional)
+
+The optional arrow reader for the Apache ORC format (found in the
+`arrow::adapters::orc` namespace) can be built by passing `-DARROW_ORC=on`.
+This is currently not supported on windows. Note that this functionality is
+still in Alpha stages, and subject to API changes without deprecation warnings.
+
### API documentation
To generate the (html) API documentation, run the following command in the
apidoc
diff --git a/python/doc/source/development.rst
b/python/doc/source/development.rst
index 1c1a308fc..01844fa18 100644
--- a/python/doc/source/development.rst
+++ b/python/doc/source/development.rst
@@ -175,6 +175,9 @@ Now build and install the Arrow C++ libraries:
If you don't want to build and install the Plasma in-memory object store,
you can omit the ``-DARROW_PLASMA=on`` flag.
+To add support for the experimental Apache ORC integration, include
+``-DARROW_ORC=on`` in these flags.
+
Now, optionally build and install the Apache Parquet libraries in your
toolchain:
@@ -205,6 +208,9 @@ Now, build pyarrow:
If you did not build parquet-cpp, you can omit ``--with-parquet`` and if
you did not build with plasma, you can omit ``--with-plasma``.
+If you built with the experimental Apache ORC integration, include
+``--with-orc`` in these flags.
+
You should be able to run the unit tests with:
.. code-block:: shell
diff --git a/python/manylinux1/build_arrow.sh b/python/manylinux1/build_arrow.sh
index ced4556e9..4d816bec9 100755
--- a/python/manylinux1/build_arrow.sh
+++ b/python/manylinux1/build_arrow.sh
@@ -58,7 +58,7 @@ for PYTHON in ${PYTHON_VERSIONS}; do
ARROW_BUILD_DIR=/arrow/cpp/build-PY${PYTHON}
mkdir -p "${ARROW_BUILD_DIR}"
pushd "${ARROW_BUILD_DIR}"
- PATH="$(cpython_path $PYTHON)/bin:$PATH" cmake -DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_PREFIX=/arrow-dist -DARROW_BUILD_TESTS=OFF
-DARROW_BUILD_SHARED=ON -DARROW_BOOST_USE_SHARED=OFF -DARROW_JEMALLOC=off
-DARROW_RPATH_ORIGIN=ON -DARROW_JEMALLOC_USE_SHARED=OFF -DARROW_PYTHON=ON
-DPythonInterp_FIND_VERSION=${PYTHON} -DARROW_PLASMA=ON ..
+ PATH="$(cpython_path $PYTHON)/bin:$PATH" cmake -DCMAKE_BUILD_TYPE=Release
-DCMAKE_INSTALL_PREFIX=/arrow-dist -DARROW_BUILD_TESTS=OFF
-DARROW_BUILD_SHARED=ON -DARROW_BOOST_USE_SHARED=OFF -DARROW_JEMALLOC=off
-DARROW_RPATH_ORIGIN=ON -DARROW_JEMALLOC_USE_SHARED=OFF -DARROW_PYTHON=ON
-DPythonInterp_FIND_VERSION=${PYTHON} -DARROW_PLASMA=ON -DARROW_ORC=ON ..
make -j5 install
popd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Do not build ORC adapter by default
> -----------------------------------------
>
> Key: ARROW-1969
> URL: https://issues.apache.org/jira/browse/ARROW-1969
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> We've been quite conservative about building add-ons -- for example the
> Plasma build is disabled by default. We should do the same for the ORC adapter
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
