[
https://issues.apache.org/jira/browse/ARROW-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321202#comment-16321202
]
ASF GitHub Bot commented on ARROW-1977:
---------------------------------------
wesm closed pull request #1466: ARROW-1977: [C++] Update windows dev docs
URL: https://github.com/apache/arrow/pull/1466
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/apidoc/Windows.md b/cpp/apidoc/Windows.md
index e7e83f194..aa3d31f1f 100644
--- a/cpp/apidoc/Windows.md
+++ b/cpp/apidoc/Windows.md
@@ -55,20 +55,16 @@ previous step:
activate arrow-dev
```
-We are using [cmake][4] tool to support Windows builds.
+We are using the [cmake][4] tool to support Windows builds.
To allow cmake to pick up 3rd party dependencies, you should set
`ARROW_BUILD_TOOLCHAIN` environment variable to contain `Library` folder
path of new created on previous step `arrow-dev` conda environment.
-For instance, if `Miniconda` was installed to default destination, `Library`
-folder path for `arrow-dev` conda environment will be as following:
+To set `ARROW_BUILD_TOOLCHAIN` environment variable visible only for current
terminal
+session you can run following. `%CONDA_PREFIX` is set by conda to the current
environment
+root by the `activate` script.
```shell
-C:\Users\YOUR_USER_NAME\Miniconda3\envs\arrow-dev\Library
-```
-
-To set `ARROW_BUILD_TOOLCHAIN` environment variable visible only for current
terminal session you can run following:
-```shell
-set
ARROW_BUILD_TOOLCHAIN=C:\Users\YOUR_USER_NAME\Miniconda3\envs\arrow-dev\Library
+set ARROW_BUILD_TOOLCHAIN=%CONDA_PREFIX%\Library
```
To validate value of `ARROW_BUILD_TOOLCHAIN` environment variable you can run
following terminal command:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Update windows dev docs
> -----------------------------
>
> Key: ARROW-1977
> URL: https://issues.apache.org/jira/browse/ARROW-1977
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Chris Bartak
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> I'll submit a PR
> - specify python3 in conda env otherwise some `vc9` packages get picked up
> - use %CONDA_PREFIX% in defining env
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
