[
https://issues.apache.org/jira/browse/ARROW-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325562#comment-16325562
]
ASF GitHub Bot commented on ARROW-1491:
---------------------------------------
xhochy commented on a change in pull request #1387: ARROW-1491: [C++] Add
casting implementations from strings to numbers or boolean
URL: https://github.com/apache/arrow/pull/1387#discussion_r161396841
##########
File path: cpp/src/arrow/compute/kernels/cast.cc
##########
@@ -17,6 +17,9 @@
#include "arrow/compute/kernels/cast.h"
+#include <boost/algorithm/string.hpp>
+#include <boost/lexical_cast.hpp>
+#include <boost/numeric/conversion/cast.hpp>
Review comment:
Wouldn't it be ok in the of small size ints just to upcast them? This should
not affect performance as it's a small temporary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Add casting implementations from strings to numbers or boolean
> --------------------------------------------------------------------
>
> Key: ARROW-1491
> URL: https://issues.apache.org/jira/browse/ARROW-1491
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Wes McKinney
> Assignee: Licht Takeuchi
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
