[
https://issues.apache.org/jira/browse/ARROW-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327948#comment-16327948
]
ASF GitHub Bot commented on ARROW-1712:
---------------------------------------
wesm commented on issue #1481: ARROW-1712: [C++] Add method to BinaryBuilder to
reserve space for value data
URL: https://github.com/apache/arrow/pull/1481#issuecomment-358134252
@xuepanchen note that each time you push any commits to GitHub on an open
PR, it creates CI builds in our Travis CI and Appveyor queues, so small
incremental pushes can impact other developers who are waiting on their builds
to run. In general, it's a good practice to wait to open a PR on a WIP patch
until you're ready to validate a completed patch and/or need code review.
If you enable Travis CI and Appveyor on your fork of Arrow, you can see CI
builds on your branches without having to open a PR to the Arrow repo. e.g.
https://travis-ci.org/wesm/arrow/branches
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Add method to BinaryBuilder to reserve space for value data
> -----------------------------------------------------------------
>
> Key: ARROW-1712
> URL: https://issues.apache.org/jira/browse/ARROW-1712
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Panchen Xue
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> The {{Resize}} and {{Reserve}} methods only reserve space for the value
> offsets. When building binary/string arrays with a known size (or some
> reasonable estimate), it would be more efficient to reserve once at the
> beginning to prevent internal reallocations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
