[
https://issues.apache.org/jira/browse/ARROW-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340205#comment-16340205
]
ASF GitHub Bot commented on ARROW-2035:
---------------------------------------
xhochy commented on a change in pull request #1516: ARROW-2035: [C++] Update
vendored cpplint.py to a Py3-compatible one
URL: https://github.com/apache/arrow/pull/1516#discussion_r163986846
##########
File path: cpp/CMakeLists.txt
##########
@@ -447,7 +447,7 @@ if (UNIX)
add_custom_target(lint ${CPPLINT_BIN}
--verbose=2
--linelength=90
-
--filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references,-build/include_order
+
--filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references,-build/include_order,-build/include_what_you_use
Review comment:
I would also like to have them, they have been very helpful. @pitrou does
the new version add a lot of errors? Then we would add and do a second PR that
fixes them (happy to take care of that).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Update vendored cpplint.py to a Py3-compatible one
> --------------------------------------------------------
>
> Key: ARROW-2035
> URL: https://issues.apache.org/jira/browse/ARROW-2035
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
>
> See https://github.com/cpplint/cpplint (BSD 3-clause)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
