[
https://issues.apache.org/jira/browse/ARROW-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341602#comment-16341602
]
Wes McKinney edited comment on ARROW-1757 at 1/26/18 9:09 PM:
--------------------------------------------------------------
Yes, that will do – we also need a boolean argument {{ordered}}. In the Python
bindings the order of the arguments is flipped
(http://arrow.apache.org/docs/python/generated/pyarrow.lib.DictionaryArray.html#pyarrow.lib.DictionaryArray.from_arrays).
Another option is to make this {{FromArray(indices, type)}} and instead pass a
dictionary type instance as {{std::shared_ptr<DataType>}} (such as produced by
{{arrow::dictionary}})
was (Author: wesmckinn):
Yes, that will do – we also need a boolean argument {{ordered}}. In the Python
bindings the order of the arguments is flipped
(http://arrow.apache.org/docs/python/generated/pyarrow.lib.DictionaryArray.html#pyarrow.lib.DictionaryArray.from_arrays).
Another option is to make this {{FromArray(indices, type)}} and instead a
dictionary type instance as {{std::shared_ptr<DataType>}} (such as produced by
{{arrow::dictionary}})
> [C++] Add DictionaryArray::FromArrays alternate ctor that can check or
> sanitized "untrusted" indices
> ----------------------------------------------------------------------------------------------------
>
> Key: ARROW-1757
> URL: https://issues.apache.org/jira/browse/ARROW-1757
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Wes McKinney
> Priority: Major
> Fix For: 0.9.0
>
>
> Related to ARROW-1658. This is related to the offset sanitization in
> {{ListArray::FromArrays}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
