[
https://issues.apache.org/jira/browse/ARROW-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341816#comment-16341816
]
ASF GitHub Bot commented on ARROW-2032:
---------------------------------------
wesm closed pull request #1519: ARROW-2032: [C++] ORC ep installs on each call
to ninja build
URL: https://github.com/apache/arrow/pull/1519
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 4f6443417..69812b97c 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -926,8 +926,7 @@ if (ARROW_ORC)
-DZLIB_HOME=${ZLIB_HOME})
ExternalProject_Add(orc_ep
- GIT_REPOSITORY "https://github.com/apache/orc";
- GIT_TAG ${ORC_VERSION}
+ URL "https://github.com/apache/orc/archive/${ORC_VERSION}.tar.gz";
BUILD_BYPRODUCTS ${ORC_STATIC_LIB}
CMAKE_ARGS ${ORC_CMAKE_ARGS})
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] ORC ep installs on each call to ninja build (even if no work to do)
> -------------------------------------------------------------------------
>
> Key: ARROW-2032
> URL: https://issues.apache.org/jira/browse/ARROW-2032
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Wes McKinney
> Assignee: Uwe L. Korn
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> On each call to {{ninja}}, the ORC EP reinstalls
>
> {code:java}
> $ ninja
> [2/48] Performing configure step for 'orc_ep'
> -- Build type: DEBUG
> -- compiler Clang version 4.0.1
> -- SNAPPY_HOME: /home/wesm/cpp-toolchain
> -- Found the Snappy header: /home/wesm/cpp-toolchain/include/snappy.h
> -- Found the Snappy library: /home/wesm/cpp-toolchain/lib/libsnappy.a
> -- ZLIB_HOME: /home/wesm/cpp-toolchain
> -- Found the ZLIB header: /home/wesm/cpp-toolchain/include/zlib.h
> -- Found the ZLIB library: /usr/lib/x86_64-linux-gnu/libz.a
> -- LZ4_HOME: /home/wesm/cpp-toolchain
> -- Found the LZ4 header: /home/wesm/cpp-toolchain/include/lz4.h
> -- Found the LZ4 library: /home/wesm/cpp-toolchain/lib/liblz4.a
> -- PROTOBUF_HOME: /home/wesm/code/arrow/cpp/thirdparty/protobuf_ep-install
> -- Found the Protobuf headers:
> /home/wesm/code/arrow/cpp/thirdparty/protobuf_ep-install/include
> -- Found the Protobuf library: /usr/lib/x86_64-linux-gnu/libprotobuf.a
> -- Found the Protoc library: /usr/lib/x86_64-linux-gnu/libprotoc.a
> -- Found the Protoc executable:
> /home/wesm/code/arrow/cpp/thirdparty/protobuf_ep-install/bin/protoc
> -- Configuring done
> -- Generating done
> -- Build files have been written to:
> /home/wesm/code/arrow/cpp/build/orc_ep-prefix/src/orc_ep-build
> [3/48] Performing build step for 'orc_ep'
> ninja: no work to do.
> [4/5] Performing install step for 'orc_ep'
> [0/1] Install the project...
> -- Install configuration: "DEBUG"
> -- Up-to-date: /home/wesm/code/arrow/cpp/build/orc_ep-install/./LICENSE
> -- Up-to-date: /home/wesm/code/arrow/cpp/build/orc_ep-install/./NOTICE
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/orc-config.hh
> -- Up-to-date: /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/Reader.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/Type.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/Exceptions.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/Statistics.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/ColumnPrinter.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/OrcFile.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/Int128.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/Vector.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/Writer.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/Common.hh
> -- Up-to-date:
> /home/wesm/code/arrow/cpp/build/orc_ep-install/include/orc/MemoryPool.hh
> -- Up-to-date: /home/wesm/code/arrow/cpp/build/orc_ep-install/lib/liborc.a
> [5/5] Completed 'orc_ep'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
