[
https://issues.apache.org/jira/browse/ARROW-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342638#comment-16342638
]
ASF GitHub Bot commented on ARROW-2028:
---------------------------------------
xhochy closed pull request #1501: ARROW-2028: [Python] extra_cmake_args needs
to be passed through shlex.split
URL: https://github.com/apache/arrow/pull/1501
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/setup.py b/python/setup.py
index 3d3831dc0..076d7e489 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -21,6 +21,7 @@
import os
import os.path as osp
import re
+import shlex
import shutil
import sys
@@ -180,8 +181,9 @@ def _run_cmake(self):
cmake_options.append('-DCMAKE_BUILD_TYPE={0}'
.format(self.build_type.lower()))
+ extra_cmake_args = shlex.split(self.extra_cmake_args)
if sys.platform != 'win32':
- cmake_command = (['cmake', self.extra_cmake_args] +
+ cmake_command = (['cmake'] + extra_cmake_args +
cmake_options + [source])
print("-- Runnning cmake for pyarrow")
@@ -197,13 +199,11 @@ def _run_cmake(self):
self.spawn(args)
print("-- Finished cmake --build for pyarrow")
else:
- import shlex
cmake_generator = 'Visual Studio 14 2015 Win64'
if not is_64_bit:
raise RuntimeError('Not supported on 32-bit Windows')
# Generate the build files
- extra_cmake_args = shlex.split(self.extra_cmake_args)
cmake_command = (['cmake'] + extra_cmake_args +
cmake_options +
[source, '-G', cmake_generator])
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] extra_cmake_args needs to be passed through shlex.split
> ----------------------------------------------------------------
>
> Key: ARROW-2028
> URL: https://issues.apache.org/jira/browse/ARROW-2028
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Affects Versions: 0.8.0
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
