[
https://issues.apache.org/jira/browse/ARROW-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345347#comment-16345347
]
ASF GitHub Bot commented on ARROW-2042:
---------------------------------------
wesm commented on issue #1520: ARROW-2042: [Plasma] Revert API change of
plasma::Create to output a MutableBuffer
URL: https://github.com/apache/arrow/pull/1520#issuecomment-361655491
Rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Plasma] Revert API change of plasma::Create to output a MutableBuffer
> ----------------------------------------------------------------------
>
> Key: ARROW-2042
> URL: https://issues.apache.org/jira/browse/ARROW-2042
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Plasma (C++)
> Reporter: Philipp Moritz
> Assignee: Philipp Moritz
> Priority: Major
> Labels: pull-request-available
>
> Reverts a part of the changes from
> [https://github.com/apache/arrow/pull/1479] concerning the plasma::Create
> API. It should output a shared pointer to a Buffer instead of a shared
> pointer to a MutableBuffer. This is needed for
> [https://github.com/apache/arrow/pull/1445] so we can return a CudaBuffer
> from plasma::Create. It also seems to be more in line with how Buffers are
> intended to be used and avoids API breakage from 0.8.0 to 0.9.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
