[ 
https://issues.apache.org/jira/browse/ARROW-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348900#comment-16348900
 ] 

ASF GitHub Bot commented on ARROW-1706:
---------------------------------------

cpcloud commented on a change in pull request #1512: ARROW-1706: [Python] 
Coerce array inputs to StructArray.from_arrays. Flip order of arguments
URL: https://github.com/apache/arrow/pull/1512#discussion_r165419767
 
 

 ##########
 File path: python/pyarrow/array.pxi
 ##########
 @@ -855,7 +858,7 @@ cdef class StructArray(Array):
         cdef DataType struct_type = struct([
             field(name, array.type)
             for name, array in
-            zip(field_names, arrays)
+            zip(names, arrays)
 
 Review comment:
   If `names` is `None` this will fail. What's the desired behavior in the case 
that `names` is `None`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [Python] StructArray.from_arrays should handle sequences that are coercible 
> to arrays
> -------------------------------------------------------------------------------------
>
>                 Key: ARROW-1706
>                 URL: https://issues.apache.org/jira/browse/ARROW-1706
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> Currently the arrays passed must be `pyarrow.Array` objects already.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to