[
https://issues.apache.org/jira/browse/ARROW-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349254#comment-16349254
]
ASF GitHub Bot commented on ARROW-1757:
---------------------------------------
wesm commented on a change in pull request #1535: ARROW-1757: [C++] Add
DictionaryArray::FromArrays alternate ctor that can check or sanitized
"untrusted" indices
URL: https://github.com/apache/arrow/pull/1535#discussion_r165483345
##########
File path: cpp/src/arrow/array.h
##########
@@ -726,6 +726,17 @@ class ARROW_EXPORT DictionaryArray : public Array {
DictionaryArray(const std::shared_ptr<DataType>& type,
const std::shared_ptr<Array>& indices);
+ /// \brief Construct DictionaryArray from dictonary data type and indices
array
+ ///
+ /// This function does the validation of the indices and input type
+ ///
+ /// \param[in] type a data type containing a dictionary
+ /// \param[in] indices an array of non-negative integers as dictionary
indices
Review comment:
add "signed" here, and perhaps say "not exceeding the size of the dictionary"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Add DictionaryArray::FromArrays alternate ctor that can check or
> sanitized "untrusted" indices
> ----------------------------------------------------------------------------------------------------
>
> Key: ARROW-1757
> URL: https://issues.apache.org/jira/browse/ARROW-1757
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Wes McKinney
> Assignee: Panchen Xue
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Related to ARROW-1658. This is related to the offset sanitization in
> {{ListArray::FromArrays}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
