[
https://issues.apache.org/jira/browse/ARROW-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351607#comment-16351607
]
ASF GitHub Bot commented on ARROW-2084:
---------------------------------------
cpcloud commented on a change in pull request #1548: ARROW-2084: [C++] Support
newer Brotli static library names
URL: https://github.com/apache/arrow/pull/1548#discussion_r165831428
##########
File path: cpp/cmake_modules/FindBrotli.cmake
##########
@@ -65,16 +65,27 @@ if (BROTLI_INCLUDE_DIR AND (PARQUET_MINIMAL_DEPENDENCY OR
BROTLI_LIBRARIES))
set(BROTLI_FOUND TRUE)
get_filename_component( BROTLI_LIBS ${BROTLI_LIBRARY_ENC} PATH )
set(BROTLI_LIB_NAME brotli)
- if (MSVC AND NOT BROTLI_MSVC_STATIC_LIB_SUFFIX)
- set(BROTLI_MSVC_STATIC_LIB_SUFFIX _static)
+ if (BROTLI_MSVC_STATIC_LIB_SUFFIX)
Review comment:
Windows builds are still failing because this is set to `_static` in
`arrow/cpp/CMakeLists.txt`. I'll submit a PR to your fork to fix the default
and update the README in apidoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Support newer Brotli static library names on Windows
> ----------------------------------------------------------
>
> Key: ARROW-2084
> URL: https://issues.apache.org/jira/browse/ARROW-2084
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> They use {{-}} instead of {{_}} now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
