[ 
https://issues.apache.org/jira/browse/ARROW-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351863#comment-16351863
 ] 

ASF GitHub Bot commented on ARROW-2089:
---------------------------------------

xhochy closed pull request #1557: ARROW-2089: [GLib] Rename to 
GARROW_TYPE_BOOLEAN for consistency
URL: https://github.com/apache/arrow/pull/1557
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/c_glib/arrow-glib/type.cpp b/c_glib/arrow-glib/type.cpp
index 68ebc9654..0642004e2 100644
--- a/c_glib/arrow-glib/type.cpp
+++ b/c_glib/arrow-glib/type.cpp
@@ -39,7 +39,7 @@ garrow_type_from_raw(arrow::Type::type type)
   case arrow::Type::type::NA:
     return GARROW_TYPE_NA;
   case arrow::Type::type::BOOL:
-    return GARROW_TYPE_BOOL;
+    return GARROW_TYPE_BOOLEAN;
   case arrow::Type::type::UINT8:
     return GARROW_TYPE_UINT8;
   case arrow::Type::type::INT8:
diff --git a/c_glib/arrow-glib/type.h b/c_glib/arrow-glib/type.h
index 378d821ef..2137c7855 100644
--- a/c_glib/arrow-glib/type.h
+++ b/c_glib/arrow-glib/type.h
@@ -26,7 +26,7 @@ G_BEGIN_DECLS
 /**
  * GArrowType:
  * @GARROW_TYPE_NA: A degenerate NULL type represented as 0 bytes/bits.
- * @GARROW_TYPE_BOOL: A boolean value represented as 1 bit.
+ * @GARROW_TYPE_BOOLEAN: A boolean value represented as 1 bit.
  * @GARROW_TYPE_UINT8: Little-endian 8bit unsigned integer.
  * @GARROW_TYPE_INT8: Little-endian 8bit signed integer.
  * @GARROW_TYPE_UINT16: Little-endian 16bit unsigned integer.
@@ -58,7 +58,7 @@ G_BEGIN_DECLS
  */
 typedef enum {
   GARROW_TYPE_NA,
-  GARROW_TYPE_BOOL,
+  GARROW_TYPE_BOOLEAN,
   GARROW_TYPE_UINT8,
   GARROW_TYPE_INT8,
   GARROW_TYPE_UINT16,
diff --git a/c_glib/test/test-array.rb b/c_glib/test/test-array.rb
index d0ade2f1e..ca9bff8c2 100644
--- a/c_glib/test/test-array.rb
+++ b/c_glib/test/test-array.rb
@@ -92,7 +92,7 @@ def test_value_data_type
   def test_value_type
     builder = Arrow::BooleanArrayBuilder.new
     array = builder.finish
-    assert_equal(Arrow::Type::BOOL, array.value_type)
+    assert_equal(Arrow::Type::BOOLEAN, array.value_type)
   end
 
   def test_slice
diff --git a/c_glib/test/test-boolean-data-type.rb 
b/c_glib/test/test-boolean-data-type.rb
index 39b812898..0c60b1087 100644
--- a/c_glib/test/test-boolean-data-type.rb
+++ b/c_glib/test/test-boolean-data-type.rb
@@ -18,7 +18,7 @@
 class TestBooleanDataType < Test::Unit::TestCase
   def test_type
     data_type = Arrow::BooleanDataType.new
-    assert_equal(Arrow::Type::BOOL, data_type.id)
+    assert_equal(Arrow::Type::BOOLEAN, data_type.id)
   end
 
   def test_to_s
diff --git a/c_glib/test/test-chunked-array.rb 
b/c_glib/test/test-chunked-array.rb
index 9287058e1..4f6a4fb0d 100644
--- a/c_glib/test/test-chunked-array.rb
+++ b/c_glib/test/test-chunked-array.rb
@@ -45,7 +45,7 @@ def test_value_type
       build_boolean_array([true, false]),
       build_boolean_array([true]),
     ]
-    assert_equal(Arrow::Type::BOOL,
+    assert_equal(Arrow::Type::BOOLEAN,
                  Arrow::ChunkedArray.new(chunks).value_type)
   end
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [GLib] Rename to GARROW_TYPE_BOOLEAN for consistency
> ----------------------------------------------------
>
>                 Key: ARROW-2089
>                 URL: https://issues.apache.org/jira/browse/ARROW-2089
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: GLib
>            Reporter: Kouhei Sutou
>            Assignee: Kouhei Sutou
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> Array name and data type name use "boolean" not "bool".
> GArrowType only uses "bool".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to