[
https://issues.apache.org/jira/browse/ARROW-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354084#comment-16354084
]
ASF GitHub Bot commented on ARROW-2044:
---------------------------------------
wesm closed pull request #1524: ARROW-2044: [JS] Typings should be a regular
dependency
URL: https://github.com/apache/arrow/pull/1524
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/js/package.json b/js/package.json
index 1c8b23604..e553b56cd 100644
--- a/js/package.json
+++ b/js/package.json
@@ -52,6 +52,8 @@
"npm-release.sh"
],
"dependencies": {
+ "@types/flatbuffers": "1.6.5",
+ "@types/node": "9.3.0",
"@types/text-encoding-utf-8": "1.0.1",
"command-line-args": "5.0.1",
"command-line-usage": "4.1.0",
@@ -62,10 +64,8 @@
},
"devDependencies": {
"@std/esm": "0.19.7",
- "@types/flatbuffers": "1.6.5",
"@types/glob": "5.0.35",
"@types/jest": "22.1.0",
- "@types/node": "9.3.0",
"ast-types": "0.10.1",
"benchmark": "2.1.4",
"coveralls": "3.0.0",
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Typings should be a regular dependency
> -------------------------------------------
>
> Key: ARROW-2044
> URL: https://issues.apache.org/jira/browse/ARROW-2044
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Reporter: Brian Hulette
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Currently some typings ({{@types/node}} and {{@types/flatbuffers}}) are
> devDependencies rather than dependencies, which prevents {{.d.ts}} files from
> being understood in downstream projects.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
