[
https://issues.apache.org/jira/browse/ARROW-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355594#comment-16355594
]
ASF GitHub Bot commented on ARROW-2095:
---------------------------------------
xhochy closed pull request #1569: ARROW-2095: [C++] Less verbose building 3rd
party deps
URL: https://github.com/apache/arrow/pull/1569
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index f07ef6b23..073471283 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -205,7 +205,7 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
option(ARROW_VERBOSE_THIRDPARTY_BUILD
"If off, output from ExternalProjects will be logged to files rather than
shown"
- ON)
+ OFF)
if (MSVC)
set(BROTLI_MSVC_STATIC_LIB_SUFFIX "-static" CACHE STRING
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 69812b97c..e10efbe49 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -44,8 +44,10 @@ if (NOT ARROW_VERBOSE_THIRDPARTY_BUILD)
LOG_BUILD 1
LOG_INSTALL 1
LOG_DOWNLOAD 1)
+ set(Boost_DEBUG FALSE)
else()
set(EP_LOG_OPTIONS)
+ set(Boost_DEBUG TRUE)
endif()
if (NOT MSVC)
@@ -130,7 +132,6 @@ endif()
# ----------------------------------------------------------------------
# Add Boost dependencies (code adapted from Apache Kudu (incubating))
-set(Boost_DEBUG TRUE)
set(Boost_USE_MULTITHREADED ON)
if (MSVC AND ARROW_USE_STATIC_CRT)
set(Boost_USE_STATIC_RUNTIME ON)
@@ -847,7 +848,8 @@ if (ARROW_WITH_GRPC)
BUILD_BYPRODUCTS "${GRPC_STATIC_LIBRARY_GPR}"
"${GRPC_STATIC_LIBRARY_GRPC}" "${GRPC_STATIC_LIBRARY_GRPCPP}"
${GRPC_BUILD_BYPRODUCTS}
${EP_LOG_OPTIONS}
- CMAKE_ARGS ${GRPC_CMAKE_ARGS})
+ CMAKE_ARGS ${GRPC_CMAKE_ARGS}
+ ${EP_LOG_OPTIONS})
else()
find_package(gRPC CONFIG REQUIRED)
set(GRPC_VENDORED 0)
@@ -882,11 +884,8 @@ if (ARROW_ORC)
CONFIGURE_COMMAND "./configure" "--disable-shared"
"--prefix=${PROTOBUF_PREFIX}" "CXXFLAGS=${EP_CXX_FLAGS}"
BUILD_IN_SOURCE 1
URL ${PROTOBUF_SRC_URL}
- LOG_DOWNLOAD 1
- LOG_CONFIGURE 1
- LOG_BUILD 1
- LOG_INSTALL 1
- BUILD_BYPRODUCTS "${PROTOBUF_STATIC_LIB}")
+ BUILD_BYPRODUCTS "${PROTOBUF_STATIC_LIB}"
+ ${EP_LOG_OPTIONS})
set (PROTOBUF_VENDORED 1)
else ()
@@ -928,7 +927,8 @@ if (ARROW_ORC)
ExternalProject_Add(orc_ep
URL "https://github.com/apache/orc/archive/${ORC_VERSION}.tar.gz";
BUILD_BYPRODUCTS ${ORC_STATIC_LIB}
- CMAKE_ARGS ${ORC_CMAKE_ARGS})
+ CMAKE_ARGS ${ORC_CMAKE_ARGS}
+ ${EP_LOG_OPTIONS})
include_directories(SYSTEM ${ORC_INCLUDE_DIR})
ADD_THIRDPARTY_LIB(orc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Suppress ORC EP build logging by default
> ----------------------------------------------
>
> Key: ARROW-2095
> URL: https://issues.apache.org/jira/browse/ARROW-2095
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> See build logs: https://travis-ci.org/apache/arrow/jobs/337777265#L9569. This
> logging should be made equivalent to other EP builds (see e.g. the protobuf
> build preceding ORC)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
