[
https://issues.apache.org/jira/browse/ARROW-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355923#comment-16355923
]
ASF GitHub Bot commented on ARROW-2111:
---------------------------------------
xhochy commented on a change in pull request #1573: ARROW-2111: [C++] Lint in
parallel
URL: https://github.com/apache/arrow/pull/1573#discussion_r166727508
##########
File path: cpp/CMakeLists.txt
##########
@@ -455,11 +455,14 @@ if (UNIX)
message(STATUS "Found cpplint executable at ${CPPLINT_BIN}")
# Full lint
- add_custom_target(lint ${CPPLINT_BIN}
+ # Balancing act: cpplint.py takes a non-trivial time to launch,
+ # so process 12 files per invocation, while still ensuring parallelism
+ add_custom_target(lint echo ${FILTERED_LINT_FILES} | xargs -n12 -P8
Review comment:
This probably won't work on Windows but I guess we don't execute this on
windows? Otherwise we could turn this into several targets that all form a
single lint target at the end and let make/ninja handle the parallelisation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Linting could be faster
> -----------------------------
>
> Key: ARROW-2111
> URL: https://issues.apache.org/jira/browse/ARROW-2111
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Antoine Pitrou
> Priority: Trivial
> Labels: pull-request-available
>
> Currently {{make lint}} style-checks C++ files sequentially (by calling
> {{cpplint}}). We could instead style-check those files in parallel.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
