[ 
https://issues.apache.org/jira/browse/ARROW-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358816#comment-16358816
 ] 

ASF GitHub Bot commented on ARROW-2120:
---------------------------------------

wesm closed pull request #1580: ARROW-2120: [C++] Add possibility to use empty 
_MSVC_STATIC_LIB_SUFFIX for Thirdparties
URL: https://github.com/apache/arrow/pull/1580
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cpp/cmake_modules/FindArrow.cmake 
b/cpp/cmake_modules/FindArrow.cmake
index bce4404a4..70defd652 100644
--- a/cpp/cmake_modules/FindArrow.cmake
+++ b/cpp/cmake_modules/FindArrow.cmake
@@ -70,7 +70,7 @@ get_filename_component(ARROW_PYTHON_LIBS 
${ARROW_PYTHON_LIB_PATH} DIRECTORY)
 if (MSVC)
   SET(CMAKE_FIND_LIBRARY_SUFFIXES ".lib" ".dll")
 
-  if (MSVC AND NOT ARROW_MSVC_STATIC_LIB_SUFFIX)
+  if (MSVC AND NOT DEFINED ARROW_MSVC_STATIC_LIB_SUFFIX)
     set(ARROW_MSVC_STATIC_LIB_SUFFIX "_static")
   endif()
 
diff --git a/cpp/cmake_modules/FindGFlags.cmake 
b/cpp/cmake_modules/FindGFlags.cmake
index 63a55d751..f71950cb5 100644
--- a/cpp/cmake_modules/FindGFlags.cmake
+++ b/cpp/cmake_modules/FindGFlags.cmake
@@ -29,7 +29,7 @@ elseif ( GFlags_HOME )
     list( APPEND _gflags_roots ${GFlags_HOME} )
 endif()
 
-if (MSVC AND NOT GFLAGS_MSVC_STATIC_LIB_SUFFIX)
+if (MSVC AND NOT DEFINED GFLAGS_MSVC_STATIC_LIB_SUFFIX)
   set(GFLAGS_MSVC_STATIC_LIB_SUFFIX "_static")
 endif()
 
diff --git a/cpp/cmake_modules/FindLz4.cmake b/cpp/cmake_modules/FindLz4.cmake
index 07707cf7c..3a89c8d02 100644
--- a/cpp/cmake_modules/FindLz4.cmake
+++ b/cpp/cmake_modules/FindLz4.cmake
@@ -29,7 +29,7 @@ elseif ( Lz4_HOME )
     list( APPEND _lz4_roots ${Lz4_HOME} )
 endif()
 
-if (MSVC AND NOT LZ4_MSVC_STATIC_LIB_SUFFIX)
+if (MSVC AND NOT DEFINED LZ4_MSVC_STATIC_LIB_SUFFIX)
   set(LZ4_MSVC_STATIC_LIB_SUFFIX "_static")
 endif()
 
diff --git a/cpp/cmake_modules/FindParquet.cmake 
b/cpp/cmake_modules/FindParquet.cmake
index 8bbe05f12..68b004c9f 100644
--- a/cpp/cmake_modules/FindParquet.cmake
+++ b/cpp/cmake_modules/FindParquet.cmake
@@ -33,7 +33,7 @@ endif()
 if (MSVC)
   SET(CMAKE_FIND_LIBRARY_SUFFIXES ".lib" ".dll")
 
-  if (MSVC AND NOT PARQUET_MSVC_STATIC_LIB_SUFFIX)
+  if (MSVC AND NOT DEFINED PARQUET_MSVC_STATIC_LIB_SUFFIX)
     set(PARQUET_MSVC_STATIC_LIB_SUFFIX "_static")
   endif()
 
diff --git a/cpp/cmake_modules/FindZSTD.cmake b/cpp/cmake_modules/FindZSTD.cmake
index 02a0c39bb..810e5c0be 100644
--- a/cpp/cmake_modules/FindZSTD.cmake
+++ b/cpp/cmake_modules/FindZSTD.cmake
@@ -29,7 +29,7 @@ elseif ( ZStd_HOME )
     list( APPEND _zstd_roots ${ZStd_HOME} )
 endif()
 
-if (MSVC AND NOT ZSTD_MSVC_STATIC_LIB_SUFFIX)
+if (MSVC AND NOT DEFINED ZSTD_MSVC_STATIC_LIB_SUFFIX)
   set(ZSTD_MSVC_STATIC_LIB_SUFFIX "_static")
 endif()
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add possibility to use empty _MSVC_STATIC_LIB_SUFFIX for Thirdparties
> ---------------------------------------------------------------------
>
>                 Key: ARROW-2120
>                 URL: https://issues.apache.org/jira/browse/ARROW-2120
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: rip.nsk
>            Assignee: rip.nsk
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to