[
https://issues.apache.org/jira/browse/ARROW-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359572#comment-16359572
]
ASF GitHub Bot commented on ARROW-1579:
---------------------------------------
xhochy commented on a change in pull request #1319: [WIP] ARROW-1579: [Java]
Adding containerized Spark Integration tests
URL: https://github.com/apache/arrow/pull/1319#discussion_r167406938
##########
File path: dev/spark_integration/spark_integration.sh
##########
@@ -0,0 +1,107 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Set up environment and working directory
Review comment:
Call `set -e` here, then a command failure in the script will lead to a
failure of the whole script. Then you can get rid of the `if [[ $? -ne 0 ]];
then` blocks later on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Add dockerized test setup to validate Spark integration
> --------------------------------------------------------------
>
> Key: ARROW-1579
> URL: https://issues.apache.org/jira/browse/ARROW-1579
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Vectors
> Reporter: Wes McKinney
> Assignee: Bryan Cutler
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> cc [~bryanc] -- the goal of this will be to validate master-to-master to
> catch any regressions in the Spark integration
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
