[ 
https://issues.apache.org/jira/browse/ARROW-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361256#comment-16361256
 ] 

ASF GitHub Bot commented on ARROW-2133:
---------------------------------------

xhochy commented on a change in pull request #1591:  ARROW-2133: [Python] Fix 
segfault on conversion of empty nested array to Pandas
URL: https://github.com/apache/arrow/pull/1591#discussion_r167650495
 
 

 ##########
 File path: cpp/src/arrow/python/arrow_to_pandas.cc
 ##########
 @@ -519,7 +519,7 @@ inline Status ConvertListsLike(PandasOptions options, 
const std::shared_ptr<Colu
   // TODO(ARROW-489): Currently we don't have a Python reference for single 
columns.
   //    Storing a reference to the whole Array would be to expensive.
 
-  OwnedRef owned_numpy_array;
+  OwnedRefNoGIL owned_numpy_array;
 
 Review comment:
   Ah, that's nice!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Segmentation fault on conversion of empty nested arrays to Pandas
> --------------------------------------------------------------------------
>
>                 Key: ARROW-2133
>                 URL: https://issues.apache.org/jira/browse/ARROW-2133
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Uwe L. Korn
>            Assignee: Antoine Pitrou
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> After resolving https://issues.apache.org/jira/browse/ARROW-2129, we still 
> cannot convert empty nested arrays to Pandas. It fails with the following 
> backtrace:
> {code:java}
> (gdb) bt
> #0 PyErr_Restore (type=type@entry=0x0, value=value@entry=0x0, 
> traceback=traceback@entry=0x0) at Python/errors.c:42
> #1 0x00007ffff7a1c48b in PyErr_Clear () at Python/errors.c:355
> #2 0x00007ffff7959320 in PyDict_GetItem (op=0x7fffe831df78, 
> key=key@entry=0x7fffec8873f0) at Objects/dictobject.c:1417
> #3 0x00007ffff0278e89 in _buffer_clear_info (arr=0x7fffe37f52b0)
> from 
> /home/uwe/miniconda3/envs/pyarrow-dev/lib/python3.6/site-packages/numpy/core/multiarray.cpython-36m-x86_64-linux-gnu.so
> #4 _array_dealloc_buffer_info (self=self@entry=0x7fffe37f52b0) at 
> numpy/core/src/multiarray/buffer.c:776
> #5 0x00007ffff022b0de in array_dealloc (self=0x7fffe37f52b0)
> from 
> /home/uwe/miniconda3/envs/pyarrow-dev/lib/python3.6/site-packages/numpy/core/multiarray.cpython-36m-x86_64-linux-gnu.so
> #6 0x00007ffff172af72 in arrow::py::OwnedRef::reset (obj=0x0, 
> this=0x7fffffff3760) at ../src/arrow/python/common.h:75
> #7 arrow::py::OwnedRef::reset (this=0x7fffffff3760) at 
> ../src/arrow/python/common.h:79
> #8 0x00007ffff174220e in arrow::py::OwnedRef::~OwnedRef (this=0x7fffffff3760, 
> __in_chrg=<optimized out>) at ../src/arrow/python/common.h:72
> #9 arrow::py::ConvertListsLike<arrow::Int64Type> (options=..., 
> col=std::shared_ptr (count 2, weak 0) 0x10b0ca0, out_values=<optimized out>,
> out_values@entry=0xf793d0) at ../src/arrow/python/arrow_to_pandas.cc:522
> #10 0x00007ffff173d833 in arrow::py::ArrowDeserializer::Visit 
> (this=this@entry=0x7fffffff3aa0, type=...) at 
> ../src/arrow/python/arrow_to_pandas.cc:1708
> #11 0x00007ffff173dc0b in 
> arrow::VisitTypeInline<arrow::py::ArrowDeserializer> (type=..., 
> visitor=visitor@entry=0x7fffffff3aa0)
> at ../src/arrow/visitor_inline.h:59
> #12 0x00007ffff1728063 in arrow::py::ArrowDeserializer::Convert 
> (out=0x7fffffff3ba8, this=0x7fffffff3aa0) at 
> ../src/arrow/python/arrow_to_pandas.cc:1744
> #13 arrow::py::ConvertColumnToPandas (options=..., options@entry=..., 
> col=std::shared_ptr (count 2, weak 0) 0x10b0ca0, 
> py_ref=py_ref@entry=0x7fffe37d4ea8,
> out=out@entry=0x7fffffff3ba8) at ../src/arrow/python/arrow_to_pandas.cc:1769
> #14 0x00007ffff17282e6 in arrow::py::ConvertArrayToPandas (options=..., 
> arr=std::shared_ptr (count 2, weak 0) 0xfe9960, py_ref=0x7fffe37d4ea8,
> out=0x7fffffff3ba8) at ../src/arrow/python/arrow_to_pandas.cc:1763
> #15 0x00007ffff211b594 in __pyx_pw_7pyarrow_3lib_5Array_26to_pandas(_object*, 
> _object*, _object*) ()
> from 
> /home/uwe/Development/arrow-repos-1/arrow/python/pyarrow/lib.cpython-36m-x86_64-linux-gnu.so
> #16 0x00007ffff7967ded in _PyCFunction_FastCallDict 
> (func_obj=func_obj@entry=0x7ffff62921b0, args=args@entry=0x11d2bd8, 
> nargs=<optimized out>,
> kwargs=kwargs@entry=0x0) at Objects/methodobject.c:231{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to