[ 
https://issues.apache.org/jira/browse/ARROW-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367846#comment-16367846
 ] 

ASF GitHub Bot commented on ARROW-2161:
---------------------------------------

cpcloud closed pull request #1615: ARROW-2161: [Python] Skip test_cython_api if 
ARROW_HOME isn't defined
URL: https://github.com/apache/arrow/pull/1615
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/python/pyarrow/tests/test_cython.py 
b/python/pyarrow/tests/test_cython.py
index 51b1a48de..df5e70ee7 100644
--- a/python/pyarrow/tests/test_cython.py
+++ b/python/pyarrow/tests/test_cython.py
@@ -56,14 +56,16 @@
 """
 
 
[email protected](
+    'ARROW_HOME' not in os.environ,
+    reason='ARROW_HOME environment variable not defined')
 def test_cython_api(tmpdir):
     """
     Basic test for the Cython API.
     """
     pytest.importorskip('Cython')
 
-    if 'ARROW_HOME' in os.environ:
-        ld_path_default = os.path.join(os.environ['ARROW_HOME'], 'lib')
+    ld_path_default = os.path.join(os.environ['ARROW_HOME'], 'lib')
 
     test_ld_path = os.environ.get('PYARROW_TEST_LD_PATH', ld_path_default)
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [Python] Skip test_cython_api if ARROW_HOME isn't defined
> ---------------------------------------------------------
>
>                 Key: ARROW-2161
>                 URL: https://issues.apache.org/jira/browse/ARROW-2161
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>    Affects Versions: 0.8.0
>            Reporter: Phillip Cloud
>            Assignee: Phillip Cloud
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> {code}
> pytest pyarrow -x --tb=short
> ===================================================== test session starts 
> =====================================================
> platform linux -- Python 3.6.3, pytest-3.3.1, py-1.5.2, pluggy-0.6.0
> rootdir: /home/phillip/Documents/code/cpp/arrow/python, inifile: setup.cfg
> collected 580 items
> pyarrow/tests/test_array.py 
> ...........................................................                   
>               [ 10%]
> pyarrow/tests/test_convert_builtin.py 
> ................................................................................
>   [ 24%]
> pyarrow/tests/test_convert_pandas.py 
> ...........................................x.......s..............................
>  [ 38%]
> .................                                                             
>                                           [ 41%]
> pyarrow/tests/test_cython.py F
> ========================================================== FAILURES 
> ===========================================================
> _______________________________________________________ test_cython_api 
> _______________________________________________________
> pyarrow/tests/test_cython.py:88: in test_cython_api
>     'build_ext', '--inplace'])
> /home/phillip/miniconda3/envs/pyarrow36/lib/python3.6/subprocess.py:291: in 
> check_call
>     raise CalledProcessError(retcode, cmd)
> E   subprocess.CalledProcessError: Command 
> '['/home/phillip/miniconda3/envs/pyarrow36/bin/python', 'setup.py', 
> 'build_ext', '--inplace']' returned non-zero exit status 1.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to