ASF GitHub Bot commented on ARROW-2178:

wesm closed pull request #1614: ARROW-2178: [JS] Fix JS html FileReader example
URL: https://github.com/apache/arrow/pull/1614

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/js/examples/read_file.html b/js/examples/read_file.html
index 3093622fc..3e082d9dc 100644
--- a/js/examples/read_file.html
+++ b/js/examples/read_file.html
@@ -29,6 +29,7 @@
 table, th, td {
   border: 1px solid black;
+  white-space: nowrap;
     <script type="text/javascript">
@@ -53,8 +54,8 @@
   var header_row = document.createElement("tr");
-  for (let column of arrowTable.columns) {
-    addCell(header_row, "th", column.name);
+  for (let field of arrowTable.schema.fields) {
+    addCell(header_row, "th", `${field}`);


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

>  [JS] Fix JS html FileReader example
> ------------------------------------
>                 Key: ARROW-2178
>                 URL: https://issues.apache.org/jira/browse/ARROW-2178
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: JavaScript
>            Reporter: Brian Hulette
>            Assignee: Paul Taylor
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 0.9.0

This message was sent by Atlassian JIRA

Reply via email to