[
https://issues.apache.org/jira/browse/ARROW-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371771#comment-16371771
]
ASF GitHub Bot commented on ARROW-2192:
---------------------------------------
wesm closed pull request #1634: ARROW-2192: [CI] Always build on master branch
and repository
URL: https://github.com/apache/arrow/pull/1634
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ci/travis_detect_changes.py b/ci/travis_detect_changes.py
index 2aeb34fa0..d60b13227 100644
--- a/ci/travis_detect_changes.py
+++ b/ci/travis_detect_changes.py
@@ -147,19 +147,25 @@ def get_unix_shell_eval(env):
def run_from_travis():
- desc = get_travis_commit_description()
- if '[skip travis]' in desc:
- # Skip everything
- affected = dict.fromkeys(ALL_TOPICS, False)
- elif '[force ci]' in desc or '[force travis]' in desc:
- # Test everything
+ if (os.environ['TRAVIS_REPO_SLUG'] == 'apache/arrow' and
+ os.environ['TRAVIS_BRANCH'] == 'master' and
+ os.environ['TRAVIS_EVENT_TYPE'] != 'pull_request'):
+ # Never skip anything on master builds in the official repository
affected = dict.fromkeys(ALL_TOPICS, True)
else:
- # Test affected topics
- affected_files = list_travis_affected_files()
- perr("Affected files:", affected_files)
- affected = get_affected_topics(affected_files)
- assert set(affected) <= set(ALL_TOPICS), affected
+ desc = get_travis_commit_description()
+ if '[skip travis]' in desc:
+ # Skip everything
+ affected = dict.fromkeys(ALL_TOPICS, False)
+ elif '[force ci]' in desc or '[force travis]' in desc:
+ # Test everything
+ affected = dict.fromkeys(ALL_TOPICS, True)
+ else:
+ # Test affected topics
+ affected_files = list_travis_affected_files()
+ perr("Affected files:", affected_files)
+ affected = get_affected_topics(affected_files)
+ assert set(affected) <= set(ALL_TOPICS), affected
perr("Affected topics:")
perr(pprint.pformat(affected))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Commits to master should run all builds in CI matrix
> ----------------------------------------------------
>
> Key: ARROW-2192
> URL: https://issues.apache.org/jira/browse/ARROW-2192
> Project: Apache Arrow
> Issue Type: Bug
> Components: Continuous Integration
> Reporter: Wes McKinney
> Assignee: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> After ARROW-2083, we are only running builds related to changed components
> with each patch in Travis CI and Appveyor.
> The problem with this is that when we merge patches to master, our Travis CI
> configuration (implemented by ASF infra to help alleviate clogged up build
> queues) is set up to cancel in-progress builds whenever a new commit is
> merged.
> So basically we could have in our timeline:
> * Patch merged affecting C++, Python
> * Patch merged affecting Java
> * Patch merged affecting JS
> So when the Java patch is merged, any in-progress C++/Python builds will be
> cancelled. And if the JS patch comes in, the Java builds would be immediately
> cancelled.
> In light of this I believe on master branch we should always run all of the
> builds unconditionally
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
