[
https://issues.apache.org/jira/browse/ARROW-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377112#comment-16377112
]
ASF GitHub Bot commented on ARROW-2209:
---------------------------------------
xhochy commented on a change in pull request #1656: ARROW-2209: [Python]
Partition columns are not correctly loaded in schema of ParquetDataset
URL: https://github.com/apache/arrow/pull/1656#discussion_r170649145
##########
File path: python/pyarrow/types.pxi
##########
@@ -529,6 +529,49 @@ cdef class Schema:
def get_field_index(self, name):
return self.schema.GetFieldIndex(tobytes(name))
+ def add_field(self, int i, Field field):
Review comment:
As this is most similar to a list, I would use the function names as defined
there but would do some adjustments, e.g.:
* Always return a new object
* Use indices instead of actual values, i.e. "`remove(x)` would be
`remove(i)`".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] Partition columns are not correctly loaded in schema of
> ParquetDataset
> -------------------------------------------------------------------------------
>
> Key: ARROW-2209
> URL: https://issues.apache.org/jira/browse/ARROW-2209
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Reporter: Uwe L. Korn
> Assignee: Uwe L. Korn
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Currently the partition columns are not included in the schema of a
> ParquetDataset. We correctly write them out in the {{_common_metadata}} file
> but we fail to load this file correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
