[
https://issues.apache.org/jira/browse/ARROW-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377165#comment-16377165
]
ASF GitHub Bot commented on ARROW-2094:
---------------------------------------
wesm closed pull request #1664: ARROW-2094: [C++] Install libprotobuf and set
PROTOBUF_HOME when using toolchain
URL: https://github.com/apache/arrow/pull/1664
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ci/travis_env_common.sh b/ci/travis_env_common.sh
index 21b6e266e..416977c13 100755
--- a/ci/travis_env_common.sh
+++ b/ci/travis_env_common.sh
@@ -47,6 +47,9 @@ if [ "$ARROW_TRAVIS_USE_TOOLCHAIN" == "1" ]; then
export ARROW_BUILD_TOOLCHAIN=$CPP_TOOLCHAIN
export BOOST_ROOT=$CPP_TOOLCHAIN
+ # Protocol buffers used by Apache ORC thirdparty build
+ export PROTOBUF_HOME=$CPP_TOOLCHAIN
+
export PATH=$CPP_TOOLCHAIN/bin:$PATH
export LD_LIBRARY_PATH=$CPP_TOOLCHAIN/lib:$LD_LIBRARY_PATH
export TRAVIS_MAKE=ninja
diff --git a/ci/travis_install_toolchain.sh b/ci/travis_install_toolchain.sh
index b5eb137ba..31076b2e7 100755
--- a/ci/travis_install_toolchain.sh
+++ b/ci/travis_install_toolchain.sh
@@ -26,6 +26,7 @@ if [ ! -e $CPP_TOOLCHAIN ]; then
conda create -y -q -p $CPP_TOOLCHAIN python=2.7 \
nomkl \
boost-cpp \
+ libprotobuf \
rapidjson \
flatbuffers \
gflags \
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Use toolchain libraries and PROTOBUF_HOME for protocol buffers
> -----------------------------------------------------------------------
>
> Key: ARROW-2094
> URL: https://issues.apache.org/jira/browse/ARROW-2094
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> This is being built from source in Travis CI at the moment; using a toolchain
> build could help with build times
> Speaking of which, libprotobuf could use some TLC in conda-forge -- I ran out
> of bandwidth to do this myself:
> https://github.com/conda-forge/staged-recipes/pull/3087. [~Max Risuhin] do
> you have time to look into adding a C++-only conda-forge package?
> cc [~jim.crist]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
