[
https://issues.apache.org/jira/browse/ARROW-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377401#comment-16377401
]
ASF GitHub Bot commented on ARROW-2213:
---------------------------------------
wesm closed pull request #1658: ARROW-2213: [JS] fix npm release
URL: https://github.com/apache/arrow/pull/1658
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/js/gulp/package-task.js b/js/gulp/package-task.js
index c42b3fc32..3390da019 100644
--- a/js/gulp/package-task.js
+++ b/js/gulp/package-task.js
@@ -47,8 +47,7 @@ const createMainPackageJson = (target, format) => (orig) => ({
main: mainExport,
types: `${mainExport}.d.ts`,
module: `${mainExport}.mjs`,
- dist: `${mainExport}.es5.min.js`,
- [`dist:es2015`]: `${mainExport}.es2015.min.js`,
+ unpkg: `${mainExport}.es5.min.js`,
[`@std/esm`]: { esm: `mjs`, warnings: false, sourceMap: true }
});
@@ -69,7 +68,7 @@ const createScopedPackageJSON = (target, format) => (({ name,
...orig }) =>
{
name: `${npmOrgName}/${packageName(target, format)}`,
version: undefined, main: `${mainExport}.js`, types:
`${mainExport}.d.ts`,
- dist: undefined, [`dist:es2015`]: undefined, module:
undefined, [`@std/esm`]: undefined
+ unpkg: undefined, module: undefined, [`@std/esm`]: undefined
}
)
)
diff --git a/js/npm-release.sh b/js/npm-release.sh
index 42cd73c0c..3ef24d3e6 100755
--- a/js/npm-release.sh
+++ b/js/npm-release.sh
@@ -27,4 +27,4 @@ npx run-s clean:all lint build
npm run test
# publish the JS target modules to npm
-npx lerna publish --yes --skip-git --force-publish=*
+npx lerna exec -- npm publish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Fix npm-release.sh
> ------------------------
>
> Key: ARROW-2213
> URL: https://issues.apache.org/jira/browse/ARROW-2213
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Reporter: Paul Taylor
> Assignee: Paul Taylor
> Priority: Major
> Labels: pull-request-available
> Fix For: JS-0.4.0
>
>
> Fix two publishing issues:
> # timeouts caused by npm 2FA settings:
> [https://github.com/lerna/lerna/issues/1137]
> # silent failure publishing the main apache-arrow module due to "dist" key
> in that module's generated package.json
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
