[
https://issues.apache.org/jira/browse/ARROW-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380922#comment-16380922
]
ASF GitHub Bot commented on ARROW-2225:
---------------------------------------
TheNeuralBit closed pull request #1670: ARROW-2225: [JS] support tables split
across buffers
URL: https://github.com/apache/arrow/pull/1670
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/js/src/ipc/reader/binary.ts b/js/src/ipc/reader/binary.ts
index 6e3c7fc5c..26bc10bb3 100644
--- a/js/src/ipc/reader/binary.ts
+++ b/js/src/ipc/reader/binary.ts
@@ -49,7 +49,7 @@ export function* readBuffers<T extends Uint8Array | Buffer |
string>(sources: It
}
for (const source of sources) {
const bb = toByteBuffer(source);
- if ((!schema && ({ schema, readMessages } = readSchema(bb))) && schema
&& readMessages) {
+ if ((!schema && ({ schema, readMessages } = readSchema(bb)) || true)
&& schema && readMessages) {
for (const message of readMessages(bb)) {
yield {
schema, message,
@@ -71,7 +71,7 @@ export async function* readBuffersAsync<T extends Uint8Array
| Buffer | string>(
let readMessages: MessageReader | null = null;
for await (const source of sources) {
const bb = toByteBuffer(source);
- if ((!schema && ({ schema, readMessages } = readSchema(bb))) && schema
&& readMessages) {
+ if ((!schema && ({ schema, readMessages } = readSchema(bb)) || true)
&& schema && readMessages) {
for (const message of readMessages(bb)) {
yield {
schema, message,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Vector reader should support reading tables split across buffers
> ---------------------------------------------------------------------
>
> Key: ARROW-2225
> URL: https://issues.apache.org/jira/browse/ARROW-2225
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Affects Versions: JS-0.3.0
> Reporter: Paul Taylor
> Assignee: Paul Taylor
> Priority: Major
> Labels: pull-request-available
> Fix For: JS-0.4.0
>
>
> PR ready: https://github.com/apache/arrow/pull/1670
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
