[ 
https://issues.apache.org/jira/browse/ARROW-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388380#comment-16388380
 ] 

ASF GitHub Bot commented on ARROW-2193:
---------------------------------------

robertnishihara commented on a change in pull request #1711: WIP ARROW-2193: 
[C++] Do not depend on Boost libraries at runtime in plasma_store
URL: https://github.com/apache/arrow/pull/1711#discussion_r172633154
 
 

 ##########
 File path: cpp/src/plasma/CMakeLists.txt
 ##########
 @@ -123,6 +123,18 @@ endif()
 
 add_executable(plasma_store store.cc)
 target_link_libraries(plasma_store plasma_static ${PLASMA_LINK_LIBS})
+SET_TARGET_PROPERTIES(plasma_store PROPERTIES
+  LINK_FLAGS "-Wl,--as-needed")
+
+if (ARROW_RPATH_ORIGIN)
 
 Review comment:
   I think this block could benefit from a short comment explaining what the 
purpose is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Plasma] plasma_store has runtime dependency on Boost shared libraries when 
> ARROW_BOOST_USE_SHARED=on
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ARROW-2193
>                 URL: https://issues.apache.org/jira/browse/ARROW-2193
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Plasma (C++)
>            Reporter: Antoine Pitrou
>            Assignee: Wes McKinney
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> I'm not sure why, but when I run the pyarrow test suite (for example 
> {{py.test pyarrow/tests/test_plasma.py}}), plasma_store forks endlessly:
> {code:bash}
>  $ ps fuwww
> USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
> [...]
> antoine  27869 12.0  0.4 863208 68976 pts/7    S    13:41   0:01 
> /home/antoine/miniconda3/envs/pyarrow/bin/python 
> /home/antoine/arrow/python/pyarrow/plasma_store -s /tmp/plasma_store40209423 
> -m 100000000
> antoine  27885 13.0  0.4 863076 68560 pts/7    S    13:41   0:01  \_ 
> /home/antoine/miniconda3/envs/pyarrow/bin/python 
> /home/antoine/arrow/python/pyarrow/plasma_store -s /tmp/plasma_store40209423 
> -m 100000000
> antoine  27901 12.1  0.4 863076 68320 pts/7    S    13:41   0:01      \_ 
> /home/antoine/miniconda3/envs/pyarrow/bin/python 
> /home/antoine/arrow/python/pyarrow/plasma_store -s /tmp/plasma_store40209423 
> -m 100000000
> antoine  27920 13.6  0.4 863208 68868 pts/7    S    13:41   0:01          \_ 
> /home/antoine/miniconda3/envs/pyarrow/bin/python 
> /home/antoine/arrow/python/pyarrow/plasma_store -s /tmp/plasma_store40209423 
> -m 100000000
> [etc.]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to