[
https://issues.apache.org/jira/browse/ARROW-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388430#comment-16388430
]
ASF GitHub Bot commented on ARROW-2236:
---------------------------------------
wesm commented on a change in pull request #1683: ARROW-2236: [JS] Add more
complete set of predicates
URL: https://github.com/apache/arrow/pull/1683#discussion_r172639828
##########
File path: js/src/Arrow.externs.js
##########
@@ -79,6 +79,12 @@ Value.prototype.gteq;
Value.prototype.lteq;
Review comment:
Is there any prior art for naming these methods in JavaScript? (in Python we
have lt, le, gt, ge, eq, ne)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [JS] Add more complete set of predicates
> ----------------------------------------
>
> Key: ARROW-2236
> URL: https://issues.apache.org/jira/browse/ARROW-2236
> Project: Apache Arrow
> Issue Type: Task
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Labels: pull-request-available
>
> Right now {{arrow.predicate}} only supports ==, >=, <=, &&, and ||
> We should also support !=, <, > at the very least
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
