ASF GitHub Bot commented on ARROW-2270:

pitrou commented on issue #1714: ARROW-2270: [Python] Fix lifetime of 
ForeignBuffer base object
URL: https://github.com/apache/arrow/pull/1714#issuecomment-370929974
   Ok, I did the change to the factory function.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [Python] ForeignBuffer doesn't tie Python object lifetime to C++ buffer 
> lifetime
> --------------------------------------------------------------------------------
>                 Key: ARROW-2270
>                 URL: https://issues.apache.org/jira/browse/ARROW-2270
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Antoine Pitrou
>            Assignee: Antoine Pitrou
>            Priority: Major
>              Labels: pull-request-available
> {{ForeignBuffer}} keeps the reference to the Python base object in the Python 
> wrapper class, not in the C++ buffer instance, meaning if the C++ buffer gets 
> passed around but the Python wrapper gets destroyed, the reference to the 
> original Python base object will be released.

This message was sent by Atlassian JIRA

Reply via email to