[ 
https://issues.apache.org/jira/browse/ARROW-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389726#comment-16389726
 ] 

ASF GitHub Bot commented on ARROW-2280:
---------------------------------------

wesm commented on a change in pull request #1719: ARROW-2280: [Python] Return 
the offset for the buffers in pyarrow.Array
URL: https://github.com/apache/arrow/pull/1719#discussion_r172887921
 
 

 ##########
 File path: python/pyarrow/array.pxi
 ##########
 @@ -483,10 +483,21 @@ cdef class Array:
         with nogil:
             check_status(ValidateArray(deref(self.ap)))
 
+    def offset(self):
 
 Review comment:
   Perhaps make this a property? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] pyarrow.Array.buffers should also include the offsets
> --------------------------------------------------------------
>
>                 Key: ARROW-2280
>                 URL: https://issues.apache.org/jira/browse/ARROW-2280
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Uwe L. Korn
>            Assignee: Uwe L. Korn
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> Currently we only return the buffers but they don't make sense without the 
> offsets for them, esp. the validity bitmap will have a non-zero offset in 
> most cases where the array was sliced.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to