[
https://issues.apache.org/jira/browse/ARROW-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wes McKinney resolved ARROW-2167.
---------------------------------
Resolution: Won't Fix
This seems to be fixed in https://github.com/apache/arrow/pull/1597. Both
CHECKIN and PRODUCTION warning levels build fine now
we are using the same CMAKE_CXX_FLAGS for EPs -- there are some additional
suppressions for ORC. I suggest we deal with this on a case by case basis going
forward
> [C++] Building Orc extensions fails with the default
> BUILD_WARNING_LEVEL=Production
> -----------------------------------------------------------------------------------
>
> Key: ARROW-2167
> URL: https://issues.apache.org/jira/browse/ARROW-2167
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Phillip Cloud
> Assignee: Wes McKinney
> Priority: Major
> Fix For: 0.9.0
>
>
> Building orc_ep fails because there are a bunch of upstream warnings like not
> providing {{override}} on virtual destructor subclasses, and using {{0}} as
> the {{nullptr}} constant and the default {{BUILD_WARNING_LEVEL}} is
> {{Production}} which includes {{-Wall}} (all warnings as errors).
> I see that there are different possible options for {{BUILD_WARNING_LEVEL}}
> so it's possible for developers to deal with this issue.
> It seems easier to let EPs build with whatever the default warning level is
> for the project rather than force our defaults on those projects.
> Generally speaking, are we using our own CXX_FLAGS for EPs other than Orc?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
