[ 
https://issues.apache.org/jira/browse/ARROW-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395442#comment-16395442
 ] 

ASF GitHub Bot commented on ARROW-2292:
---------------------------------------

pitrou commented on a change in pull request #1736: ARROW-2292: [Python] Rename 
frombuffer() to py_buffer()
URL: https://github.com/apache/arrow/pull/1736#discussion_r173853843
 
 

 ##########
 File path: python/pyarrow/io.pxi
 ##########
 @@ -849,6 +850,15 @@ def frombuffer(object obj):
     return pyarrow_wrap_buffer(buf)
 
 
+def frombuffer(object obj):
+    """
+    Deprecated alias for `py_buffer`.
+    """
+    warnings.warn("pa.frombuffer() is deprecated, use pa.py_buffer() instead",
+                  DeprecationWarning)
 
 Review comment:
   Not by default, though it will show up in interactive settings such as 
IPython. I can switch to FutureWarning if you prefer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] More consistent / intuitive name for pyarrow.frombuffer
> ----------------------------------------------------------------
>
>                 Key: ARROW-2292
>                 URL: https://issues.apache.org/jira/browse/ARROW-2292
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Wes McKinney
>            Assignee: Antoine Pitrou
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> Now that we have {{pyarrow.foreign_buffer}}, things are a bit odd. We could 
> call {{frombuffer}} something like {{py_buffer}} instead?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to