[
https://issues.apache.org/jira/browse/ARROW-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398362#comment-16398362
]
ASF GitHub Bot commented on ARROW-2304:
---------------------------------------
xhochy closed pull request #1743: ARROW-2304: [C++] Fix HDFS MultipleClients
unit test
URL: https://github.com/apache/arrow/pull/1743
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/src/arrow/io/io-hdfs-test.cc b/cpp/src/arrow/io/io-hdfs-test.cc
index 610a91fbc..e02215b5e 100644
--- a/cpp/src/arrow/io/io-hdfs-test.cc
+++ b/cpp/src/arrow/io/io-hdfs-test.cc
@@ -181,6 +181,8 @@ TYPED_TEST(TestHadoopFileSystem, ConnectsAgain) {
TYPED_TEST(TestHadoopFileSystem, MultipleClients) {
SKIP_IF_NO_DRIVER();
+ ASSERT_OK(this->MakeScratchDir());
+
std::shared_ptr<HadoopFileSystem> client1;
std::shared_ptr<HadoopFileSystem> client2;
ASSERT_OK(HadoopFileSystem::Connect(&this->conf_, &client1));
@@ -189,7 +191,7 @@ TYPED_TEST(TestHadoopFileSystem, MultipleClients) {
// client2 continues to function after equivalent client1 has shutdown
std::vector<HdfsPathInfo> listing;
- EXPECT_OK(client2->ListDirectory(this->scratch_dir_, &listing));
+ ASSERT_OK(client2->ListDirectory(this->scratch_dir_, &listing));
ASSERT_OK(client2->Disconnect());
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] MultipleClients test in io-hdfs-test fails on trunk
> ---------------------------------------------------------
>
> Key: ARROW-2304
> URL: https://issues.apache.org/jira/browse/ARROW-2304
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Critical
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> This fails for me locally:
> {code}
> [ RUN ] TestHadoopFileSystem/0.MultipleClients
> ../src/arrow/io/io-hdfs-test.cc:192: Failure
> Value of: s.ok()
> Actual: false
> Expected: true
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
