[
https://issues.apache.org/jira/browse/ARROW-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402136#comment-16402136
]
ASF GitHub Bot commented on ARROW-2318:
---------------------------------------
wesm closed pull request #1761: ARROW-2318: [Plasma] Run plasma store tests
with unique socket
URL: https://github.com/apache/arrow/pull/1761
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/cpp/src/plasma/test/client_tests.cc
b/cpp/src/plasma/test/client_tests.cc
index 15f9e7cd1..07e0f9c6a 100644
--- a/cpp/src/plasma/test/client_tests.cc
+++ b/cpp/src/plasma/test/client_tests.cc
@@ -22,6 +22,8 @@
#include <sys/types.h>
#include <unistd.h>
+#include <random>
+
#include "plasma/client.h"
#include "plasma/common.h"
#include "plasma/plasma.h"
@@ -38,14 +40,20 @@ class TestPlasmaStore : public ::testing::Test {
// TODO(pcm): At the moment, stdout of the test gets mixed up with
// stdout of the object store. Consider changing that.
void SetUp() {
+ std::mt19937 rng;
+ rng.seed(std::random_device()());
+ std::string store_index = std::to_string(rng());
+
std::string plasma_directory =
test_executable.substr(0, test_executable.find_last_of("/"));
- std::string plasma_command =
- plasma_directory +
- "/plasma_store -m 1000000000 -s /tmp/store 1> /dev/null 2> /dev/null
&";
+ std::string plasma_command = plasma_directory +
+ "/plasma_store -m 1000000000 -s /tmp/store" +
+ store_index + " 1> /dev/null 2> /dev/null &";
system(plasma_command.c_str());
- ARROW_CHECK_OK(client_.Connect("/tmp/store", "",
PLASMA_DEFAULT_RELEASE_DELAY));
- ARROW_CHECK_OK(client2_.Connect("/tmp/store", "",
PLASMA_DEFAULT_RELEASE_DELAY));
+ ARROW_CHECK_OK(
+ client_.Connect("/tmp/store" + store_index, "",
PLASMA_DEFAULT_RELEASE_DELAY));
+ ARROW_CHECK_OK(
+ client2_.Connect("/tmp/store" + store_index, "",
PLASMA_DEFAULT_RELEASE_DELAY));
}
virtual void Finish() {
ARROW_CHECK_OK(client_.Disconnect());
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] TestPlasmaStore.MultipleClientTest is flaky (hangs) in release builds
> ---------------------------------------------------------------------------
>
> Key: ARROW-2318
> URL: https://issues.apache.org/jira/browse/ARROW-2318
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Wes McKinney
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Here's my setup:
> * Ubuntu 16.04
> * clang 5.0 (gcc 5.4.0 base toolchain)
> I can reliably get {{release/client_tests}} to hang. I hit this while looking
> at a possible 0.9.0 release candidate
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
