[
https://issues.apache.org/jira/browse/ARROW-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402144#comment-16402144
]
ASF GitHub Bot commented on ARROW-2321:
---------------------------------------
wesm closed pull request #1762: ARROW-2321: [C++] Release verification script
fails with if CMAKE_INSTALL_LIBDIR is not $ARROW_HOME/lib
URL: https://github.com/apache/arrow/pull/1762
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/dev/release/verify-release-candidate.bat
b/dev/release/verify-release-candidate.bat
index 27157da66..bc05b23a9 100644
--- a/dev/release/verify-release-candidate.bat
+++ b/dev/release/verify-release-candidate.bat
@@ -28,7 +28,7 @@
@rem cmake ^
@rem git ^
@rem boost-cpp ^
-@rem snappy zlib brotli gflags lz4-c zstd || exit /B
+@rem snappy zlib brotli gflags lz4-c zstd -c conda-forge || exit /B
@rem Then run from the directory containing the RC tarball
@rem
diff --git a/dev/release/verify-release-candidate.sh
b/dev/release/verify-release-candidate.sh
index 502b45bf8..34aff209a 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -104,7 +104,7 @@ setup_miniconda() {
numpy \
pandas \
six \
- cython=0.27.3
+ cython=0.27.3 -c conda-forge
source activate arrow-test
}
@@ -115,6 +115,7 @@ test_and_install_cpp() {
pushd cpp/build
cmake -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
+ -DCMAKE_INSTALL_LIBDIR=$ARROW_HOME/lib \
-DARROW_PLASMA=on \
-DARROW_PYTHON=on \
-DARROW_BOOST_USE_SHARED=on \
@@ -138,6 +139,7 @@ install_parquet_cpp() {
pushd parquet-cpp/build
cmake -DCMAKE_INSTALL_PREFIX=$PARQUET_HOME \
+ -DCMAKE_INSTALL_LIBDIR=$PARQUET_HOME/lib \
-DCMAKE_BUILD_TYPE=release \
-DPARQUET_BOOST_USE_SHARED=on \
-DPARQUET_BUILD_TESTS=off \
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Release verification script fails with if CMAKE_INSTALL_LIBDIR is not
> $ARROW_HOME/lib
> -------------------------------------------------------------------------------------------
>
> Key: ARROW-2321
> URL: https://issues.apache.org/jira/browse/ARROW-2321
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Fix up shortly
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
